Fix #26099: Crash when opening score and pressing direction key #26322
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #26099
Problem is as follows:
NotationInteraction::nudgeAnchors
which causes a crash becauseNotationInteraction::startEditGrip
was never called.The solution I've gone for in this PR is to check whether a grip edit has started before calling
nudgeAnchors
. We could potentially include an additional step where we immediately start editing the barline's grips on open - but my feeling is that this behaviour is probably undesirable (see video).grips.mov