Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct horizontal spacing of big time signatures with hidden staves #26319

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

mike-spa
Copy link
Contributor

@mike-spa mike-spa commented Feb 4, 2025

Resolves: #26281

The issue has nothing to with parts, nor is it limited to the cross-staves option. If the (system object-) staff where the big time signature would normally appear is not visible (be it because the user manually hid it or because the "Hide empty staves" option is turned on) the time signature wasn't considered for spacing, hence colliding with notation. This is now fixed.

@oktophonie oktophonie requested a review from miiizen February 4, 2025 10:50
@oktophonie oktophonie added the vtests This PR produces approved changes to vtest results label Feb 5, 2025
@mike-spa mike-spa merged commit 4c8baf8 into musescore:master Feb 6, 2025
10 of 11 checks passed
@mike-spa mike-spa deleted the fixBigTimeSigBug branch February 17, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vtests This PR produces approved changes to vtest results
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Big time signatures overlap notation when parts are hidden
3 participants