-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix corruption on section break in parts #26308
Merged
mike-spa
merged 2 commits into
musescore:master
from
mike-spa:fixCorruptionOnSectionBreakInParts
Feb 5, 2025
Merged
Fix corruption on section break in parts #26308
mike-spa
merged 2 commits into
musescore:master
from
mike-spa:fixCorruptionOnSectionBreakInParts
Feb 5, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
reviewed
Feb 3, 2025
Wouldn't you need to fix
|
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 3, 2025
Backport of musescore#26308 plus fixing most clazy warnings
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 3, 2025
Backport of musescore#26308 plus fixing most clazy warnings
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 3, 2025
Backport of musescore#26308 plus fixing most clazy warnings
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 3, 2025
Backport of musescore#26308 plus fixing most clazy warnings
9bc30f8
to
1fb01ff
Compare
Jojo-Schmitz
reviewed
Feb 3, 2025
oktophonie
approved these changes
Feb 3, 2025
…the ElementType enum to ensure it stays behind all notation
1fb01ff
to
847046a
Compare
miiizen
approved these changes
Feb 5, 2025
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 5, 2025
Backport of musescore#26308 plus fixing most clazy warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #24970
For every other system element, we conventionally set the track to zero. I don't know why it was chosen to set it to
muse::nidx
(i.e. an invalid value) for LayoutBreak elements. This was causing the section breaks to be saved with spurious staff index information, which was causing them to not be relinked on reading because their staves wouldn't match. Simply setting their tracks to zero seems to resolve both the corruption examples reported in the issue.The second commit cleans up an unrelated thing about the drawing order (i.e. a cleaner way of making sure that LayoutBreak elements are drawn behind all notation).