Fix #25145: Crash relating to StaffTypeChange
#26289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-spa
reviewed
Jan 31, 2025
mathesoncalum
force-pushed
the
25145-stafftype_change_crash
branch
from
d9669e1 to
b7b4fb7
Compare
mike-spa
approved these changes
Feb 3, 2025
|
Tested on Win10 @mathesoncalum The crash still occurs on my side.. bandicam.2025-02-04.18-50-29-869.mp4 |
mathesoncalum
force-pushed
the
25145-stafftype_change_crash
branch
2 times, most recently
from
ae0627c to
3650d6d
Compare
|
Tested on Win10, Mac13.6, LinuxUbuntu24.04.1 LTS - it is no longer possible to apply multiple staff type change marks to the same measure with caused to crash previously |
4 tasks
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 5, 2025
Backport of musescore#26289 and fix clazy warnings
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 6, 2025
Backport of musescore#26289 and fix clazy warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves (partially): #25145
This is a preventative fix - with these changes it is no longer possible to apply multiple
StaffTypeChangesto the same measure (see video for updated behaviour). This PR initially included some logic for handling corruptedStaffTypeChangesin existing scores (ae0627c) but this ended up causing another type of corruption that is arguably more severe than the crash.stcdrag.mov