Fix crash on selecting arpeggio #26010
Conversation
|
|
||
| const PointF gripCanvasPos = gripsPositions()[static_cast<int>(grip)] + pageOffset; | ||
| if (gripIndex >= gripsCount()) { | ||
| return result; |
There was a problem hiding this comment.
Good to have this check, in any case. But I would also like this to be fixed higher up, namely in NotationViewInputController::handleLeftClick, where we startEditGrip on a default grip which happens to be the MIDDLE grip, which isn't available for Arpeggios. The most elegant solution I can think of would be to introduce something like a
virtual Grip defaultGrip() const;
which every EngravingItem can specify for itself. Or even without making it virtual, it could just be in EngravingItem and return a sensible choice depending on the gripCount.
There was a problem hiding this comment.
We have a virtual defaultGrip method already - seems it just isn't being used here. I'll update handleLeftClick to use that grip.
There was a problem hiding this comment.
Ha! Lol, didn't know. Good job!
miiizen
force-pushed
the
arpeggio-crash
branch
from
731546c to
ecf76c3
Compare
Resolves: #26396
Crash on selecting arpeggio. I'm not sure when this slipped in, but it only occurs in master.