Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panels scroll when focus moves out of view #25664

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

shubham-shinde-442
Copy link
Contributor

@shubham-shinde-442 shubham-shinde-442 commented Nov 27, 2024

Resolves (partially, for the instruments mixer panels): #25571

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@shubham-shinde-442
Copy link
Contributor Author

To address #25571 for the Properties panel, can we use StyledFlickable in InspectorSectionDelegate.qml to obtain the height of the navigated item and ContentY..... or would there be a better solution? I'm open to suggestions for this.

@cbjeukendrup
Copy link
Contributor

cbjeukendrup commented Dec 1, 2024

@shubham-shinde-442 I don't understand exactly what you mean, but can https://doc.qt.io/qt-6/qml-qtquick-item.html#mapToItem-method help, to retrieve the bounding box of an item in the coordinates of any other item (for example the contentItem of the StyledListView that contains all the inspector sections)?

Copy link
Contributor

@mathesoncalum mathesoncalum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @shubham-shinde-442 - just a couple of feedback points.

It's a shame we can't use positionViewAtindex in our version of TreeView - this would make life a lot easier!

@zacjansheski
Copy link
Contributor

Tested on MacOS 14, Windows 11, Ubuntu 22.04.3. Approved

@mathesoncalum mathesoncalum merged commit 8fc3c78 into musescore:master Dec 16, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants