Fix regroup rhythms not maintaining selection #25661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AxelMatstoms
force-pushed
the
regroup-rhythms-maintain-selection
branch
from
ac0541b to
1f9f0ed
Compare
mathesoncalum
requested changes
Dec 5, 2024
There was a problem hiding this comment.
Looks good - thanks @AxelMatstoms! I've left a couple of comments.
cbjeukendrup
reviewed
Dec 5, 2024
AxelMatstoms
force-pushed
the
regroup-rhythms-maintain-selection
branch
from
1f9f0ed to
8aec1b7
Compare
Fixes: musescore#24955 cmdResetNoteAndRestGroupings already saved the current selection before actually regrouping rhythms. This commit updates the method to set the selection to the values saved in the case that the user had selected a range before calling regroup rhythms. Also adds test to verify that selection is maintained when regrouping rhythms.
AxelMatstoms
force-pushed
the
regroup-rhythms-maintain-selection
branch
from
8aec1b7 to
84036ca
Compare
mathesoncalum
approved these changes
Dec 5, 2024
|
Tested on MacOS 14, Windows 11, Ubuntu 22.04.3. Approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #24955
cmdResetNoteAndRestGroupings already saved the current selection before actually regrouping rhythms. This commit updates the method to set the selection to the values saved in the case that the user had selected a range before calling regroup rhythms.
Also adds test to verify that selection is maintained when regrouping rhythms.