Fix #21953: Crash on regroup rhythms in some scores (Master) #22314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Chord* c1 = findLinkedChord(cr1, score->staff(staffIdx)); | ||
| Chord* c2 = findLinkedChord(cr2, score->staff(staffIdx + sm)); | ||
|
|
||
| IF_ASSERT_FAILED(c1) { |
Contributor
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 10, 2024
Backport of musescore#22314 Seems to build upon an backport of musescore#10654, which got closed in favor of musescore#13183
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 10, 2024
Backport of musescore#22314 Seems to build upon an backport of musescore#10654, which got closed in favor of musescore#13183
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 11, 2024
Backport of musescore#22314 Seems to build upon an backport of musescore#10654, which got closed in favor of musescore#13183
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #21953
This is the result of a corrupted score where the notes in the excerpts don't match those in the main score. The crash happens when calling
findLinkedChord. This seems to be a pretty rare situation and its unclear how the score reached this state. Regardless, we should try to avoid a crash here with a null check (and assert).