Skip to content

Fix #19019: fix empty figured-bass in MusicXML export #21772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cbjeukendrup merged 1 commit into from
Mar 11, 2024
Merged

Fix #19019: fix empty figured-bass in MusicXML export #21772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/importexport/musicxml/internal/musicxml/exportxml.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6337,6 +6337,9 @@ static void figuredBass(XmlWriter& xml, track_idx_t strack, track_idx_t etrack,
if (track == wtrack) {
if (e->type() == ElementType::FIGURED_BASS) {
const FiguredBass* fb = dynamic_cast<const FiguredBass*>(e);
if (fb->items().empty()) {
return;
}
//LOGD("figuredbass() track %d seg %p fb %p seg %p tick %d ticks %d cr %p tick %d ticks %d",
// track, seg, fb, fb->segment(), fb->segment()->tick(), fb->ticks(), cr, cr->tick(), cr->actualTicks());
bool extend = fb->ticks() > cr->actualTicks();
Expand All @@ -6352,7 +6355,6 @@ static void figuredBass(XmlWriter& xml, track_idx_t strack, track_idx_t etrack,
const bool writeDuration = fb->ticks() < cr->actualTicks();
writeMusicXML(fb, xml, true, crEndTick.ticks(), fbEndTick.ticks(),
writeDuration, divisions);

// Check for changing figures under a single note (each figure stored in a separate segment)
for (Segment* segNext = seg->next(); segNext && segNext->element(track) == NULL; segNext = segNext->next()) {
for (EngravingItem* annot : segNext->annotations()) {
Expand Down