Import and export cross voice arpeggios correctly #21619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miiizen
force-pushed
the
xml-arpeggios
branch
from
b3f6957 to
988b55b
Compare
mike-spa
reviewed
Feb 27, 2024
| @@ -65,6 +65,18 @@ class NoteList | |||
| std::vector<StartStopList> _staffNoteLists; // The note start/stop times in all staves | |||
| }; | |||
|
|
|||
| /** | |||
| List of note start/stop times in a voice in all staves. | |||
There was a problem hiding this comment.
Don't think this comment was meant to be copied
mike-spa
approved these changes
Feb 27, 2024
miiizen
force-pushed
the
xml-arpeggios
branch
from
988b55b to
890ea38
Compare
cbjeukendrup
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure we write/read the
number=".."field of<arpeggiate>tags correctly to export/import cross voice/staff arpeggios.The PR employs a similar behaviour to the older #8506 with regards to importing arpeggios where the number attribute is not specified. If arpeggiate tags without a number specified occur on two chords sounding at the same time, they will be connected by one arpeggio. This resolves incorrect export from some software such as Dolet.