Skip to content

Conversation

@XiaoMigros
Copy link
Contributor

@XiaoMigros XiaoMigros commented Jan 12, 2024

Resolves: #20962
Resolves #13469

When changing the duration of several selected notes or rests at once, those notes or rests remain selected.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@XiaoMigros XiaoMigros force-pushed the pad-toggle-selection branch 3 times, most recently from b3ecf2f to 88c3e1c Compare January 18, 2024 20:40
@XiaoMigros

This comment was marked as outdated.

@XiaoMigros XiaoMigros force-pushed the pad-toggle-selection branch 3 times, most recently from 2f9298a to 9a82ace Compare January 24, 2024 19:30
@XiaoMigros XiaoMigros force-pushed the pad-toggle-selection branch 2 times, most recently from c0a02fa to ce151fd Compare January 29, 2024 19:45
@ghost ghost requested a review from RomanPudashkin February 6, 2024 11:58
@ghost
Copy link

ghost commented Feb 6, 2024

Behaviour not perfect in a case where multiple notes or rests are converted to tuplets, but this is a wider problem with tuplet generation which should be solved separately and generally. In other cases it works as expected (when multiple notes are changed, they are list-selected).

@ghost ghost requested a review from bkunda February 6, 2024 12:01
@XiaoMigros XiaoMigros force-pushed the pad-toggle-selection branch 16 times, most recently from 25c5d4f to d972bc9 Compare February 9, 2024 19:14
@XiaoMigros XiaoMigros force-pushed the pad-toggle-selection branch 4 times, most recently from 5cbe2ad to 9db1bfe Compare February 9, 2024 20:29
@XiaoMigros XiaoMigros changed the title Fix #20962: Save selection on padToggle Fix #20962: Keep selection when deleting, changing note/rest lengths Feb 9, 2024
@XiaoMigros XiaoMigros force-pushed the pad-toggle-selection branch from 9db1bfe to ca3595d Compare February 9, 2024 21:26
@bkunda

This comment was marked as outdated.

@cbjeukendrup

This comment was marked as resolved.

@ghost ghost requested review from cbjeukendrup and removed request for RomanPudashkin February 12, 2024 15:09
@bkunda
Copy link

bkunda commented Feb 12, 2024

🟢 Re-tested on macOS. Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants