-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Fix #20962: Keep selection when deleting, changing note/rest lengths #20984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cbjeukendrup
merged 2 commits into
musescore:master
from
XiaoMigros:pad-toggle-selection
Feb 17, 2024
Merged
Fix #20962: Keep selection when deleting, changing note/rest lengths #20984
cbjeukendrup
merged 2 commits into
musescore:master
from
XiaoMigros:pad-toggle-selection
Feb 17, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b3ecf2f to
88c3e1c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
2f9298a to
9a82ace
Compare
c0a02fa to
ce151fd
Compare
ghost
approved these changes
Feb 6, 2024
|
Behaviour not perfect in a case where multiple notes or rests are converted to tuplets, but this is a wider problem with tuplet generation which should be solved separately and generally. In other cases it works as expected (when multiple notes are changed, they are list-selected). |
bkunda
approved these changes
Feb 6, 2024
25c5d4f to
d972bc9
Compare
5cbe2ad to
9db1bfe
Compare
9db1bfe to
ca3595d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
|
🟢 Re-tested on macOS. Approved. |
fa1f8d3 to
525a11a
Compare
cbjeukendrup
approved these changes
Feb 17, 2024
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 17, 2024
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 17, 2024
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 9, 2024
2 tasks
This was referenced Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #20962
Resolves #13469
When changing the duration of several selected notes or rests at once, those notes or rests remain selected.