Fix MSVC compiler warnings

[Jojo-Schmitz]

• reg.: unreferenced formal parameter (C4100)
• reg.: conversion from 'size_t' to 'int', possible loss of data (C4267)

there's one warning left:

Severity	Code	Description	Project	File	Line	Suppression State
Warning	C4702	unreachable code	braille	...\src\braille\internal\braillecode.cpp	1030	

which I don't understand, code in question:

MuseScore/src/braille/internal/braillecode.cpp

Lines 1025 to 1044 in 1df93bb

	braille_code* findBrailleCode(std::vector<braille_code*> code_lst, std::string code, bool partial_match)
	{
	if (partial_match) {
	std::vector<std::string> codes = splitCodes(code);
	for (braille_code* br : code_lst) {
	std::vector<std::string> lst = splitCodes(br->code);
	if (codes.size() > lst.size()) {
	return nullptr;
	}
	for (size_t i=0; i < codes.size(); i++) {
	if (codes[i] != lst[i]) {
	return nullptr;
	}
	}
	return br;
	}
	} else {

Possible fix:

• reg.: unreachable code (C4702)
• reg.: declaration hides function parameter (C4457)
• Some 1000 warnings C4996, all in internal VS code, 'xutility', lines 1141, 1255 and 1256 and '__msvc_iter_core.hpp', lines 488-492, nothing we can fix, so disabled it.

And now also a compiler error:

• reg.: undeclared identifier (C2065)

[cbjeukendrup]

About that other warning: it's indeed a bit cryptical, but might relate to the fact that there's a return statement at the end of the body of the for loop, causing it to be executed at most once and thus making the loop unnecessary. It's indeed a slightly suspicious situation. @shoogle Could you please double-check that piece of code?

[Jojo-Schmitz]

I see! And can guess what it really is ment to be, @shoogle, please check

[shoogle]

@Jojo-Schmitz, the braille code was written by @TuanLa1972. The findBrailleCode() function doesn't appear to be used anywhere, but my guess is return br; was correct (i.e. your change is wrong) and the two return nullptr; lines above were supposed to be continue; instead.

[Jojo-Schmitz]

Ah, I see, my guess wasn't just wrong, it was downright bad, thanks!
Amended to follow your sugggestion.
@TuanLa1972 please review.
If it is unused code though, we might as well just remove it?

[TuanLa1972]

Sorry to say that I don't remember what idea was behind findBrailleCode()function. Please remove it. Also, some other findXXX functions in braille.h aren't used anywher and they can be removed too. I guess we've changed the algo and they are not necessary anymore. Vào CN, 19 thg 11, 2023 vào lúc 06:53 Peter Jonas < ***@***.***> đã viết:

…

@Jojo-Schmitz <https://github.com/Jojo-Schmitz>, the braille code was written by @TuanLa1972 <https://github.com/TuanLa1972>. The findBrailleCode() function doesn't appear to be used anywhere, but my guess is return br; was correct (i.e. your change is wrong) and the two return nullptr; lines above were supposed to be continue; instead. — Reply to this email directly, view it on GitHub <#20022 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APTBLS6XJ7H7QMEXLVIANRLYFFC7BAVCNFSM6AAAAAA7KXGJRGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJXGY4DANBWHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[Jojo-Schmitz]

OK, removed

[shoogle]

I'm happy with the Braille find... functions being removed. They are not used anywhere.

The other changes seem reasonable as well.

[Jojo-Schmitz]

Now I also got and fixed a compiler error