Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4] Add single stroke caesura #12863

Merged
merged 1 commit into from
May 10, 2023

Conversation

Jojo-Schmitz
Copy link
Contributor

@Jojo-Schmitz Jojo-Schmitz commented Aug 15, 2022

it got added with SMuFL 1.4

Resolves: https://musescore.org/en/node/334302

Adds a single string to the translations

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 15, 2022
it got added with SMuFL 1.4

Backport of musescore#12863
@Jojo-Schmitz Jojo-Schmitz force-pushed the caesura-single-stroke branch from 30d466a to 182e083 Compare August 16, 2022 08:26
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 28, 2022
it got added with SMuFL 1.4

Backport of musescore#12863
@cbjeukendrup cbjeukendrup added the strings Affects translatable strings label Sep 26, 2022
@Jojo-Schmitz
Copy link
Contributor Author

Just came up again in https://musescore.org/en/comment/1169310

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023
it got added with SMuFL 1.4

Backport of musescore#12863
@Jojo-Schmitz Jojo-Schmitz force-pushed the caesura-single-stroke branch from 182e083 to c4fdb31 Compare March 14, 2023 12:42
@Jojo-Schmitz
Copy link
Contributor Author

This one is awaiting review since quite long too

@Jojo-Schmitz Jojo-Schmitz force-pushed the caesura-single-stroke branch from c4fdb31 to ee2bb45 Compare March 14, 2023 13:23
@Jojo-Schmitz Jojo-Schmitz force-pushed the caesura-single-stroke branch 2 times, most recently from 4b3d7ec to cf45443 Compare March 18, 2023 12:52
@Jojo-Schmitz
Copy link
Contributor Author

Can we get this merged, please

@Jojo-Schmitz
Copy link
Contributor Author

Came up again in https://musescore.org/en/node/348837

@cbjeukendrup
Copy link
Contributor

I was wondering one thing, shouldn't we handle it in ExportBrailleImpl::brailleBreath too? Or maybe even use isCaesura there?

@Jojo-Schmitz Jojo-Schmitz force-pushed the caesura-single-stroke branch from cf45443 to e46a08b Compare May 1, 2023 18:13
@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented May 1, 2023

Of course, thanks for pointing that out, I believe my PR is older than the Braille export...
chantCaesura was missing there too BTW.

Using isCaesura is even better!

@Jojo-Schmitz Jojo-Schmitz force-pushed the caesura-single-stroke branch from e46a08b to e796e1c Compare May 1, 2023 18:27
it got added with SMuFL 1.4
@Jojo-Schmitz Jojo-Schmitz force-pushed the caesura-single-stroke branch from e796e1c to a74fe55 Compare May 1, 2023 19:20
@RomanPudashkin RomanPudashkin merged commit ffe2053 into musescore:master May 10, 2023
@Jojo-Schmitz Jojo-Schmitz deleted the caesura-single-stroke branch May 10, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
strings Affects translatable strings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants