Skip to content

Conversation

cbjeukendrup
Copy link
Member

Resolves: #12001

At a first glance, I see no problems with these fonts.

@RomanPudashkin RomanPudashkin merged commit 1886f23 into musescore:master Jun 29, 2022
@Tantacrul
Copy link
Contributor

@oktophonie - we have a little task for you! :)

@cbjeukendrup cbjeukendrup deleted the finalefonts branch June 29, 2022 12:23
@Tantacrul
Copy link
Contributor

I've noticed that the ottava marks are fine for Broadway but not for Maestro (at least, I doubt Maestro is meant to look like this...)

Broadway
image

Maestro
image

@Tantacrul
Copy link
Contributor

Oddly, Maestro is fine with these marks:
image

This is the only issue I've been able to spot so far. @oktophonie may find more.

However, in general, they are both holding up really well!

@cbjeukendrup
Copy link
Member Author

That '8' seems to be a Maestro Text problem. I believe we are using the "Text" variant of the font in that place, but Maestro Text does not contain the ottava symbols, also not that '8' which should be at U+E510. However, at U+E888 I seem to recognize that small 8 that I see in your example. And I suspect that the '15' is from either Leland or Bravura (whichever is used as a fallback).

@Tantacrul
Copy link
Contributor

Thought so. Perhaps I can modify Maestro text for now (until they fix it themselves)?

@Tantacrul
Copy link
Contributor

Tantacrul commented Jun 29, 2022

@cbjeukendrup - two points:

  1. I'm unable to find the regular versions of Maestro or Broadway in the Resources folder when I open the MS4 package. Same with the regular version of Bravura too, which is weird. Any idea why?

image

  1. I don't think we use the text fonts for 8ve markings - mainly because I never added them to LelandText.

@cbjeukendrup
Copy link
Member Author

Ah, that's because for some reason the "regular" fonts are compiled into the executable, so you won't find them as an .otf file. Instead, you could take them from the source code. Here is Maestro: https://github.com/musescore/MuseScore/blob/master/fonts/finalemaestro/FinaleMaestro.otf
And here is Bravura: https://github.com/musescore/MuseScore/blob/master/fonts/bravura/Bravura.otf
(Click "view raw" to download them.)

@cbjeukendrup
Copy link
Member Author

cbjeukendrup commented Jun 29, 2022

2. I don't think we use the text fonts for 8ve markings - mainly because I never added them to LelandText.

We really do. That would mean that ottava markings fall back to Bravura, and that seems to be the case...

@Tantacrul
Copy link
Contributor

Got it. Thanks!

@its-not-nice
Copy link
Contributor

its-not-nice commented Jun 29, 2022

Ah. Well, we really should be using the music font rather than the Text font (by the same logic as for dynamics). Am looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Optional Task] Add Finale's Maestro and Broadway fonts
4 participants