-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #331007: [MusicXML import] support tie element #11485
fix #331007: [MusicXML import] support tie element #11485
Conversation
@lvinken: My backport to 3.x fails an mtest, "testUnterminatedTies" (see here), seems related to this change. any idea how to deal with it? That test doesn't seem to exist in master, see: MuseScore/src/importexport/musicxml/tests/tst_mxml_io.cpp Lines 255 to 256 in a623af3
I see, that test isn't in 3.x either, but had been added with #8556 into the 3.6.2_backend_musicxml branch. |
It is quite unfortunate that MusicXML import in the backend and the application itself are not in sync ... |
Yes, it is. And unfortunate that the author of those is no longer around. |
That test got added via (the port of) musescore#8566, but now fails after the backport of musescore#11485. ToDo: check whether the changes for musescore#8566 (Handle hanging ties) still work and whether/how to amend that test or the code.
That test got added via (the port of) musescore#8566, but now fails after the backport of musescore#11485. ToDo: check whether the changes for musescore#8566 (Handle hanging ties) still work and whether/how to amend that test or the code.
That test got added via (the port of) musescore#8566, but now fails after the backport of musescore#11485. ToDo: check whether the changes for musescore#8566 (Handle hanging ties) still work and whether/how to amend that test or the code.
Resolves: https://musescore.org/en/node/331007
Create a tie on MusicXML import when either a tie or a tied element is present.