Skip to content

Conversation

lvinken
Copy link
Contributor

@lvinken lvinken commented Mar 8, 2022

Resolves:
https://musescore.org/en/node/328730
https://musescore.org/en/node/321095

Update the MusicXML version to 4.0 on export (second and final part of #321095). This prepares for future use of MusicXML 4.0 features.
Increase MusicXML MAX_NUMBER_LEVEL to 16 to match the 4.0 spec, which allows export of more overlapping hairpins etc.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 8, 2022
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 8, 2022
@Jojo-Schmitz
Copy link
Contributor

First part (Import MusicXML 4.0, resp. update the validation schema files) was in #10060

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 15, 2022
@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Mar 17, 2022

Any known (and good) reason why the vtests fail?`
I can't magine how that one-line change might have caused this.
Maybe a rebase solves this?

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 17, 2022
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 17, 2022
@@ -0,0 +1,3198 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Contributor

@Jojo-Schmitz Jojo-Schmitz Mar 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is not yet used, or is it?

Adding void maxNumberLevel() { mxmlImportTestRef("testMaxNumberLevel"); } to https://github.com/musescore/MuseScore/blob/master/src/importexport/musicxml/tests/tst_mxml_io.cpp seems to work and pass

Edit 1: no, it doesn't...

Edit 2: it actually needs to be void maxNumberLevel() { mxmlMscxExportTestRef("testMaxNumberLevel"); }
(see below for some additional change that'd be needed to make it pass)

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 17, 2022
@@ -0,0 +1,2315 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE score-partwise PUBLIC "-//Recordare//DTD MusicXML 3.1 Partwise//EN" "http://www.musicxml.org/dtds/partwise.dtd">
<score-partwise version="3.1">
Copy link
Contributor

@Jojo-Schmitz Jojo-Schmitz Mar 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be 4.0?

Edit: That is what's keeping the unit test (if added, see above) from passing

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 17, 2022
@lvinken lvinken force-pushed the musicxml-4.0-export branch from d3e41af to 5673f97 Compare March 18, 2022 06:35
@lvinken
Copy link
Contributor Author

lvinken commented Mar 18, 2022

Fixed. Should have mentioned it yesterday: I wasn't done yet.

@Jojo-Schmitz
Copy link
Contributor

Thanks.

@vpereverzev
Copy link
Member

vpereverzev commented Apr 25, 2022

@lvinken looks like some of your recent changes has broken a couple of MXML unit tests.

see a876cef

Could you please take a look? For now, I had to temporarily disable them

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Apr 25, 2022

I've fixed the 3 failing tests as a 2nd commit to #10442

And it most likely isn't @lvinken's failt but mine, from #10586's 2nd commit, which adds/enables a bunch of those tests, which in turn were not prepared for MusicXML 4.0

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 12, 2022
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 12, 2022
@lvinken lvinken deleted the musicxml-4.0-export branch May 27, 2022 14:03
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants