-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Fix #321095: Support MusicXML 4.0 (export) #10761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
First part (Import MusicXML 4.0, resp. update the validation schema files) was in #10060 |
Any known (and good) reason why the vtests fail?` |
Backport of musescore#10761, part 1
@@ -0,0 +1,3198 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is not yet used, or is it?
Adding void maxNumberLevel() { mxmlImportTestRef("testMaxNumberLevel"); }
to https://github.com/musescore/MuseScore/blob/master/src/importexport/musicxml/tests/tst_mxml_io.cpp seems to work and pass
Edit 1: no, it doesn't...
Edit 2: it actually needs to be void maxNumberLevel() { mxmlMscxExportTestRef("testMaxNumberLevel"); }
(see below for some additional change that'd be needed to make it pass)
@@ -0,0 +1,2315 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> | |||
<!DOCTYPE score-partwise PUBLIC "-//Recordare//DTD MusicXML 3.1 Partwise//EN" "http://www.musicxml.org/dtds/partwise.dtd"> | |||
<score-partwise version="3.1"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be 4.0?
Edit: That is what's keeping the unit test (if added, see above) from passing
d3e41af
to
5673f97
Compare
Fixed. Should have mentioned it yesterday: I wasn't done yet. |
Thanks. |
Backport of musescore#10761, part 1
Backport of musescore#10761, part 1
Resolves:
https://musescore.org/en/node/328730
https://musescore.org/en/node/321095
Update the MusicXML version to 4.0 on export (second and final part of #321095). This prepares for future use of MusicXML 4.0 features.
Increase MusicXML MAX_NUMBER_LEVEL to 16 to match the 4.0 spec, which allows export of more overlapping hairpins etc.