Skip to content

[MU4] Fix #9995: Double/halve note duration skips values in note entry mode #10668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

RomanPudashkin
Copy link
Contributor

Resolves: #9995

@RomanPudashkin RomanPudashkin marked this pull request as draft February 25, 2022 09:57
@bkunda
Copy link

bkunda commented Feb 25, 2022

Tested in MacOS and Windows. Shortcuts work well across standard and TAB staves.
One related change I did notice (from MS3 behaviour) is that the 0 key no longer enters an open string in tablature staves (instead, it enters a rest). Not sure if this was changed somewhere along the line, but I think it should continue to enter open string "0" -- particularly as this key is also necessary to enter the "10" fret.
@RomanPudashkin let me know if this can be addressed in this PR, or if you'd like me to raise this separately :-)

@RomanPudashkin RomanPudashkin marked this pull request as ready for review February 25, 2022 11:00
@RomanPudashkin
Copy link
Contributor Author

One related change I did notice (from MS3 behaviour) is that the 0 key no longer enters an open string in tablature staves

@bkunda I can reproduce this bug in the master, so let's rise it as a separate issue

@bkunda
Copy link

bkunda commented Feb 25, 2022

Sure! I'll do this now

@RomanPudashkin RomanPudashkin merged commit d6b6812 into musescore:master Feb 25, 2022
@RomanPudashkin RomanPudashkin deleted the double_half_durations branch February 3, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MU4 Issue] Design question regarding W/Q shortcuts + Shift+W/Q [MU4 Issue] Double/halve note duration skips values in note entry mode
3 participants