Add 2 Couperin ornaments #10412

sammik · 2022-01-30T21:49:05Z

Added two french ornaments - Tremblement appuyé (Couperin), and Pincé (Couperin)

I signed CLA
I made sure the code in the PR follows the coding rules
I made sure the code compiles on my machine
I made sure there are no unnecessary changes in the code
I made sure the title of the PR reflects the core meaning of the issue you are solving
I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
I made sure the commit message title starts with "fix #424242:" if there is a related issue
I created the test (mtest, vtest, script test) to verify the changes I made

Jojo-Schmitz · 2022-01-31T07:51:07Z

Possible merge conflict with #10282

Jojo-Schmitz · 2022-01-31T07:56:42Z

src/engraving/playback/metaparsers/internal/symbolsmetaparser.cpp

@@ -286,6 +286,7 @@ void SymbolsMetaParser::doParse(const Ms::EngravingItem* item, const RenderingCo
        types.emplace(mpe::ArticulationType::UpMordent);
        break;
    case Ms::SymId::ornamentMordent:
+    case Ms::SymId::ornamentPinceCouperin:


Trying to port this PR to 3.x (for inclusion in PR #9000) and wonder where this change needs to go (or whether at all)?

Also unsure where Ms::SymId::ornamentTremplementCouperin would belong, why it is missing here?

And whether I'd need to something similar for PR #10282?

Ms::SymId::ornamentTreblementCouperin was there already

MuseScore/src/engraving/playback/metaparsers/internal/symbolsmetaparser.cpp

Line 313 in b8de8be

case Ms::SymId::ornamentTremblementCouperin:

Ah, explains my 2nd question. Not the first nor the last though-

Ah, last question is answered as well: I added them already.
Remains the first?

You did
https://github.com/musescore/MuseScore/pull/10282/files#diff-8b5549a030b47fea7e9325a0e5c467a946b66db0992545010dadfb8257521aa4

I don't think this applies to MU3, since it is part of the new MPE playback system.

Yep, just found that out myself seconds ago, thanks

Good, answers the 1st question as : no need for this in 3.x

Tremblement appuyé (Couperin), Pincé (Couperin) Backport of PR musescore#10412

sammik · 2022-01-31T15:53:17Z

Possible merge conflict with #10282 (And typo in commit- and PR title, "ornamnets")

Should I change commit message?

Jojo-Schmitz · 2022-01-31T15:57:38Z

Only if you haven't got anything better to do ;-)

sammik · 2022-01-31T16:09:15Z

My wife thinks, I have :) po 31. 1. 2022 o 16:57 Joachim Schmitz ***@***.***> napísal(a):

…

Only if you haven't got anything better to do ;-) — Reply to this email directly, view it on GitHub <#10412 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMR3UXJZ3F5D2MQRXH7R3TUY2WPZANCNFSM5NEYRBGQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: ***@***.***>

-- Samuel Mikláš

Jojo-Schmitz · 2022-01-31T17:56:15Z

That's when the WAF* kicks in...

*) Women's Acceptancy Factor ;-)

sammik · 2022-01-31T21:00:57Z

That's when the WAF* kicks in...

*) Women's Acceptancy Factor ;-)

:)
S*WAF === true
*Sleeping

Tremblement appuyé (Couperin), Pincé (Couperin) Backport of PR musescore#10412

Jojo-Schmitz · 2022-03-17T14:53:47Z

rebase needed

RobFog · 2022-05-01T13:37:52Z

Rebase still needed.

sammik · 2022-05-01T14:24:16Z

Rebase done

Tremblement appuyé (Couperin), Pincé (Couperin) Backport of PR musescore#10412

src/engraving/libmscore/rendermidi.cpp

Jojo-Schmitz · 2023-05-10T13:06:15Z

Rebase needed

sammik · 2023-05-11T00:02:43Z

Rebase needed

done

Tremblement appuyé (Couperin), Pincé (Couperin)

sammik · 2023-05-11T05:30:34Z

@RomanPudashkin
please, look at this, if You have some time

Tremblement appuyé (Couperin), Pincé (Couperin) Leftover from an earlier backport of musescore#10412

Jojo-Schmitz reviewed Jan 31, 2022

View reviewed changes

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jan 31, 2022

Add 2 Couperin ornaments

756e4b6

Tremblement appuyé (Couperin), Pincé (Couperin) Backport of PR musescore#10412

sammik changed the title ~~Add 2 Couperin ornamnets~~ Add 2 Couperin ornaments Jan 31, 2022

sammik force-pushed the couperin-ornaments branch from 924af5b to 1864aca Compare January 31, 2022 20:54

Jojo-Schmitz mentioned this pull request Feb 3, 2022

[MU3] Fix GH#7449: Almost everything suitable for 3.6.3 or 3.7.0 #9000

Closed

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Feb 4, 2022

Add 2 Couperin ornaments

ff6d5d6

Tremblement appuyé (Couperin), Pincé (Couperin) Backport of PR musescore#10412

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Feb 5, 2022

Add 2 Couperin ornaments

bced102

Tremblement appuyé (Couperin), Pincé (Couperin) Backport of PR musescore#10412

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Feb 7, 2022

Add 2 Couperin ornaments

a4921cf

Tremblement appuyé (Couperin), Pincé (Couperin) Backport of PR musescore#10412

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Feb 24, 2022

Add 2 Couperin ornaments

c8614a4

Tremblement appuyé (Couperin), Pincé (Couperin) Backport of PR musescore#10412

Jojo-Schmitz mentioned this pull request Mar 17, 2022

[MU4] Fix #328451: Add 2 (baroque) trills #10282

Merged

sammik force-pushed the couperin-ornaments branch from 1864aca to dc33d8e Compare May 1, 2022 14:23

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 12, 2022

Add 2 Couperin ornaments

fcb805e

Tremblement appuyé (Couperin), Pincé (Couperin) Backport of PR musescore#10412

sammik force-pushed the couperin-ornaments branch from dc33d8e to 2e9061d Compare July 18, 2022 21:39

cbjeukendrup added the strings Affects translatable strings label Sep 26, 2022

Jojo-Schmitz mentioned this pull request Mar 1, 2023

Fix GH#7449: Almost everything suitable for 3.6.3 or 3.7.0 Jojo-Schmitz/MuseScore#80

Closed

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023

Add 2 Couperin ornaments

0d6e53b

Tremblement appuyé (Couperin), Pincé (Couperin) Backport of PR musescore#10412

cbjeukendrup reviewed Mar 14, 2023

View reviewed changes

src/engraving/libmscore/rendermidi.cpp Show resolved Hide resolved

cbjeukendrup requested a review from RomanPudashkin March 14, 2023 12:11

sammik force-pushed the couperin-ornaments branch from 2e9061d to e4394c2 Compare May 11, 2023 00:00

sammik force-pushed the couperin-ornaments branch from e4394c2 to 3c1ab8c Compare May 11, 2023 00:07

Add 2 Couperin ornaments

ad06c36

Tremblement appuyé (Couperin), Pincé (Couperin)

sammik force-pushed the couperin-ornaments branch from 3c1ab8c to ad06c36 Compare May 11, 2023 00:16

RomanPudashkin approved these changes May 11, 2023

View reviewed changes

RomanPudashkin merged commit 2648a41 into musescore:master May 11, 2023

sammik deleted the couperin-ornaments branch May 11, 2023 08:49

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 8, 2024

Add 2 Couperin ornaments, MusicXML im-/export

1105337

Tremblement appuyé (Couperin), Pincé (Couperin) Leftover from an earlier backport of musescore#10412

Jojo-Schmitz mentioned this pull request May 8, 2024

Fix nonsense warnings in MusicXML Jojo-Schmitz/MuseScore#470

Merged

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 8, 2024

Add 2 Couperin ornaments, MusicXML im-/export

8a52fe1

Tremblement appuyé (Couperin), Pincé (Couperin) Leftover from an earlier backport of musescore#10412

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 13, 2024

Add 2 Couperin ornaments, MusicXML im-/export

58514ad

Tremblement appuyé (Couperin), Pincé (Couperin) Leftover from an earlier backport of musescore#10412

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 13, 2024

Add 2 Couperin ornaments, MusicXML im-/export

465720a

Tremblement appuyé (Couperin), Pincé (Couperin) Leftover from an earlier backport of musescore#10412

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add 2 Couperin ornaments #10412

Add 2 Couperin ornaments #10412

sammik commented Jan 30, 2022

Jojo-Schmitz commented Jan 31, 2022 •

edited

Loading

Jojo-Schmitz Jan 31, 2022 •

edited

Loading

sammik Jan 31, 2022

Jojo-Schmitz Jan 31, 2022 •

edited

Loading

sammik Jan 31, 2022

cbjeukendrup Jan 31, 2022

Jojo-Schmitz Jan 31, 2022 •

edited

Loading

sammik commented Jan 31, 2022

Jojo-Schmitz commented Jan 31, 2022

sammik commented Jan 31, 2022 via email

Jojo-Schmitz commented Jan 31, 2022

sammik commented Jan 31, 2022

Jojo-Schmitz commented Mar 17, 2022

RobFog commented May 1, 2022

sammik commented May 1, 2022

Jojo-Schmitz commented May 10, 2023

sammik commented May 11, 2023

sammik commented May 11, 2023

Add 2 Couperin ornaments #10412

Add 2 Couperin ornaments #10412

Conversation

sammik commented Jan 30, 2022

Jojo-Schmitz commented Jan 31, 2022 • edited Loading

Jojo-Schmitz Jan 31, 2022 • edited Loading

Choose a reason for hiding this comment

sammik Jan 31, 2022

Choose a reason for hiding this comment

Jojo-Schmitz Jan 31, 2022 • edited Loading

Choose a reason for hiding this comment

sammik Jan 31, 2022

Choose a reason for hiding this comment

cbjeukendrup Jan 31, 2022

Choose a reason for hiding this comment

Jojo-Schmitz Jan 31, 2022 • edited Loading

Choose a reason for hiding this comment

sammik commented Jan 31, 2022

Jojo-Schmitz commented Jan 31, 2022

sammik commented Jan 31, 2022 via email

Jojo-Schmitz commented Jan 31, 2022

sammik commented Jan 31, 2022

Jojo-Schmitz commented Mar 17, 2022

RobFog commented May 1, 2022

sammik commented May 1, 2022

Jojo-Schmitz commented May 10, 2023

sammik commented May 11, 2023

sammik commented May 11, 2023

Jojo-Schmitz commented Jan 31, 2022 •

edited

Loading

Jojo-Schmitz Jan 31, 2022 •

edited

Loading

Jojo-Schmitz Jan 31, 2022 •

edited

Loading

Jojo-Schmitz Jan 31, 2022 •

edited

Loading