[MU4] Fix #310158: Don't null terminate MIDI text meta events #10374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port of PR musescore#7003 to the master branch
Jojo-Schmitz
force-pushed
the
MIDI-no-null-term
branch
from
b59ef69 to
7043405
Compare
8 tasks
vpereverzev
approved these changes
Jan 25, 2022
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jan 25, 2022
Port of PR musescore#7003 resp. backport of PR musescore#10374
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 4, 2022
Port of PR musescore#7003 resp. backport of PR musescore#10374
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 5, 2022
Port of PR musescore#7003 resp. backport of PR musescore#10374
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 7, 2022
Port of PR musescore#7003 resp. backport of PR musescore#10374
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 24, 2022
Port of PR musescore#7003 resp. backport of PR musescore#10374
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 12, 2022
Port of PR musescore#7003 resp. backport of PR musescore#10374
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 5, 2023
Port of PR musescore#7003 resp. backport of PR musescore#10374
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/310158
Port of PR #7003 to the master branch
This PR prevents the null terminator of MIDI text meta events from getting exported into the MIDI files.
Apparently the unit tests for MIDI import/export are a) currently disabled and b) only for import anyway, unlike the 3.x branch, so no tests have been amended in this PR