Beam custom direction #10010
Merged
Beam custom direction #10010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With the exception of this vtest, the vtests are failing as expected. I need to think about this case in the morning.
|
|
Is this (the flipped B) not just down to the middle-line-contextual-stem-direction-flipping (now undone with #9969 )? |
its-not-nice
approved these changes
Dec 8, 2021
RomanPudashkin
approved these changes
Dec 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a beam group was flipped (i.e., the direction is not the default), the slant for the beam was not calculated correctly. More specifically, beams would often be flat if it were supposed to be slanted, or vice versa. This would occur either when there were multiple voices on a single staff, or if the beam group was flipped manually.
This should now be fixed.