Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab order (keyboard navigation) in Format > Style > Rests is all over the place #25530

Closed
4 tasks done
cbjeukendrup opened this issue Nov 15, 2024 · 2 comments · Fixed by #25859
Closed
4 tasks done

Tab order (keyboard navigation) in Format > Style > Rests is all over the place #25530

cbjeukendrup opened this issue Nov 15, 2024 · 2 comments · Fixed by #25859
Labels
accessibility Issues related to accessibility community Issues particularly suitable for community contributors to work on good first issue Issues suitable for first-time contributors. See https://github.com/musescore/MuseScore/contribute P2 Priority: Medium

Comments

@cbjeukendrup
Copy link
Contributor

Issue type

Accessibility issue (e.g. for keyboard-only or screen reader users)

Description with steps to reproduce

See video

Supporting files, videos and screenshots

Schermopname.2024-11-15.om.18.28.57.mov

What is the latest version of MuseScore Studio where this issue is present?

master

Regression

Choose option...

Operating system

*

Additional context

Allowing tab navigation into and out of the QML parts of this dialog is probably not in scope for this issue. Keyboard navigation in UIs that mix QML and QtWidgets is an unsolved problem (well, there are known workarounds, but in our case it's extra complicated because in QML we have our own keyboard nav implementation).

Should be solved in Qt Creator's design view; go to editstyle.ui, click the tiny "edit tab stops" button at the top of the window, and figure out how that works. Tip: right-click > "tab order list" is useful.

Checklist

  • This report follows the guidelines for reporting bugs and issues
  • I have verified that this issue has not been logged before, by searching the issue tracker for similar issues
  • I have attached all requested files and information to this report
  • I have attempted to identify the root problem as concisely as possible, and have used minimal reproducible examples where possible
@muse-bot muse-bot added the accessibility Issues related to accessibility label Nov 15, 2024
@cbjeukendrup
Copy link
Contributor Author

Possibly, other pages are affected too. Updating the keyboard navigation order has to be done after every edit to the dialog, but is very easy to forget.

@MarcSabatella
Copy link
Contributor

FWIW, I often find it simpler to just edit the UI file directly (as text) for this type of thing.

@bkunda bkunda moved this to To do in MuseScore Studio 4.5 Nov 19, 2024
@bkunda bkunda added the P2 Priority: Medium label Nov 19, 2024
@bkunda bkunda added good first issue Issues suitable for first-time contributors. See https://github.com/musescore/MuseScore/contribute community Issues particularly suitable for community contributors to work on labels Nov 19, 2024
kurtmetzger added a commit to kurtmetzger/MuseScore that referenced this issue Dec 17, 2024
@oktophonie oktophonie moved this from To do to In Progress in MuseScore Studio 4.5 Dec 17, 2024
@oktophonie oktophonie moved this from Available to In progress in Community Projects Dec 17, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Community Projects Dec 17, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in MuseScore Studio 4.5 Dec 17, 2024
woolie pushed a commit to woolie/MuseScore that referenced this issue Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issues related to accessibility community Issues particularly suitable for community contributors to work on good first issue Issues suitable for first-time contributors. See https://github.com/musescore/MuseScore/contribute P2 Priority: Medium
Projects
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants