This method seems to be called very often; while simply updating the state of the note input bar once, it is already called maybe 10 times. While this method is not very expensive, it is not completely trivial either, and it is very redundant to call it again and again.
We could either cache the mu::notation::NoteInputState, or just eliminate it completely and use mu::engraving::InputState directly.
(This just caught my attention while debugging something else; perhaps it is not significant enough to spend time on. Feel free to close in that case.)