Properties: need to press "undo" twice to undo "reset to default" for compound properties like align and scale

[cbjeukendrup]

To Reproduce
Steps to reproduce the behavior:

1. Create score
2. Add time signature
3. Change its scale in the Properties panel; modify both horizontal and vertical scale.
4. Click '...' > "reset to default".
5. Press undo
   -> expected: both horizontal and vertical scale are back at their customised value
   -> actual: only vertical scale is restored; horizontal scale is still at 100%
6. Press undo again
   -> now horizontal scale is also back at its customised value

Same story for the "align" property of text.

Expected behavior
Since it takes one action to reset both values, it should take one press of the "undo" button to undo that.

Screenshots
If applicable, add screenshots to help explain your problem.

Schermopname.2023-01-08.om.20.39.39.mov

[Tejkh1]

Can you please suggest the file, which I should see.

[cbjeukendrup]

@Tejkh1 For example, in the case of the Align property, this is the source of the problem:

MuseScore/src/inspector/view/qml/MuseScore/Inspector/text/TextInspectorView.qml

Lines 171 to 176 in 43daf47

	onRequestResetToDefault: {
	if (root.model) {
	root.model.horizontalAlignment.resetToDefault()
	root.model.verticalAlignment.resetToDefault()
	}
	}

"Reset to default" is called for both property items individually, which results in two separate "undoable actions" in the C++ code which is called eventually as a result, namely

MuseScore/src/inspector/models/abstractinspectormodel.cpp

Lines 271 to 296 in 43daf47

	void AbstractInspectorModel::onPropertyValueChanged(const mu::engraving::Pid pid, const QVariant& newValue)
	{
	if (isEmpty()) {
	return;
	}
	beginCommand();
	for (mu::engraving::EngravingItem* element : m_elementList) {
	IF_ASSERT_FAILED(element) {
	continue;
	}
	mu::engraving::PropertyFlags ps = element->propertyFlags(pid);
	if (ps == mu::engraving::PropertyFlags::STYLED) {
	ps = mu::engraving::PropertyFlags::UNSTYLED;
	}
	PropertyValue propValue = valueToElementUnits(pid, newValue, element);
	element->undoChangeProperty(pid, propValue, ps);
	}
	updateNotation();
	endCommand();
	}

because for each call individually, the code is surrounded by beginCommand()/endCommand().

So, it is quite easy to see what's the problem, but seeing a proper solution may be a bit more challenging!