ALSA sequencer device leaks when toggling MIDI ON/OFF

[hselasky]

Describe the bug
ALSA sequencer device leaks when toggling MIDI ON/OFF

To Reproduce

1. Build musescore with ALSA MIDI support enabled.
2. Click on the MIDI DIN-5 plug ICON four times.
3. Run "aconnect -l"
4. Verify that multiple ALSA MIDI instances are registered.

Expected behavior
At any time only one instance should be registered.

Screenshots
Not applicable.

Platform information

• OS: FreeBSD (MuseScore 3.6.1)

Additional context
Patches are attached:

1. patch-audio_drivers_alsa.cpp.txt
2. patch-audio_drivers_mididriver.cpp.txt
3. patch-audio_drivers_alsamidi.h.txt

[hselasky]

@probonopd : FYI

[hselasky]

Looks like this is fixed in MU4.

[Jojo-Schmitz]

Guess I'll add that fix to PR #9000 then (for the 3.x branch).

But better upgrade to 3.6.2 anyway, 3.6.1 is outdated since a year.

[Jojo-Schmitz]

Please check the GitHub CI artifact (Linux AppImage) from PR #9000, I can't, don't have a LInux box to test

[hselasky]

@Jojo-Schmitz : Looks good!

[hselasky]

2234 hans 39 20 0 780M 443M select 1 0:53 98.56% mscore

Looks like a polling bug somewhere.

[Jojo-Schmitz]

Where, in the artifact from PR #9000, in 3.6.x or in master?

[hselasky]

@Jojo-Schmitz : This is something specific to FreeBSD and nothing to worry about for MuseScore.

[Jojo-Schmitz]

I see, thanks

[Tantacrul]

We won't be making any fixes for 3.x.

It would be great to test this again on MS4. Closing for now. Let me know if there is a reason to reopen.

[probonopd]

MuseScore in FreeBSD is still 3.x...
https://www.freshports.org/audio/musescore/