optimized the timeline panel updating

musescore · Oct 11, 2021 · dac9188 · dac9188
1 parent 72f2738
commit dac9188
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/notation/view/widgets/timeline.h b/src/notation/view/widgets/timeline.h
@@ -136,6 +136,7 @@ class Timeline : public QGraphicsView, public mu::async::Asyncable
     bool handleEvent(QEvent* event);
 
     void updateGridView() { updateGrid(-1, -1); }
+    void updateGridFromCmdState();
     void setNotation(mu::notation::INotationPtr notation);
 
     TRowLabels* labelsColumn() const;
@@ -264,7 +265,6 @@ private slots:
     const TimelineTheme& activeTheme() const;
 
     void updateGridFull() { updateGrid(0, -1); }
-    void updateGridFromCmdState();
 
     QColor colorBox(QGraphicsRectItem* item);
 

diff --git a/src/notation/view/widgets/timelineview.cpp b/src/notation/view/widgets/timelineview.cpp
@@ -38,14 +38,14 @@ class TimelineAdapter : public QSplitter, public ui::IDisplayableWidget
         setFocusPolicy(Qt::NoFocus);
         setHandleWidth(0);
         setSizePolicy(QSizePolicy::Expanding, QSizePolicy::Expanding);
-        setObjectName("TimeLineAdapter");
+        setObjectName("TimelineAdapter");
 
         m_msTimeline = new Ms::Timeline(this);
     }
 
     void updateView()
     {
-        m_msTimeline->updateGridView();
+        m_msTimeline->updateGridFromCmdState();
     }
 
     void setNotation(INotationPtr notation)
@@ -120,7 +120,7 @@ void TimelineView::componentComplete()
             return;
         }
 
-        notation->notationChanged().onNotify(this, [=] {
+        notation->undoStack()->stackChanged().onNotify(this, [=] {
             updateView();
         });