Skip to content

Network Audio Fixes (pt 2) #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 7, 2022
Merged

Network Audio Fixes (pt 2) #112

merged 4 commits into from
Sep 7, 2022

Conversation

alex-shortt
Copy link
Collaborator

@alex-shortt alex-shortt commented Sep 7, 2022 •
edited
Loading

forgot to push v2.3.1 so I reverted #110 and resubmitted

  • properly handle enabling / disabling voice prop for network
  • refactor connection.ts code to be a bit more readable
  • store media connections rather than voice streams in network layer
  • refactor how new/stale connections are found / handled
  • bring mic permission code to own hook
  • handle iphone bug where audio plays on earpiece
  • handle disconnecting media connections when voice disabled

@alex-shortt alex-shortt merged commit 616a946 into dev Sep 7, 2022
@alex-shortt alex-shortt deleted the as-audio-fixes branch September 7, 2022 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alex-shortt