fix: fix and move test to relevant file.

murongg · Aug 9, 2020 · e95f237 · e95f237
1 parent 94b2961
commit e95f237
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 27 deletions.
diff --git a/test/specs/files.spec.js b/test/specs/files.spec.js
@@ -202,31 +202,4 @@ describe("bump [files...]", () => {
 
     expect(files.json("package.json")).to.deep.equal({ version: "1.2.3" });
   });
-
-  it("should skip specified version scripts if present", () => {
-    files.create("package.json", {
-      version: "1.2.3",
-      scripts: {
-        preversion: "echo preversion",
-        version: "echo version",
-      }
-    });
-    files.create("package-lock.json", { version: "1.2.3" });
-
-    let cli = bump("major --skip-version-scripts preversion postversion");
-
-    expect(cli).to.have.stderr("");
-    expect(cli).to.have.exitCode(0);
-
-    expect(cli).to.have.stdout(
-      `${check} Script skipped preversion\n` +
-      `${check} Updated package.json to 2.0.0\n` +
-      `${check} Updated package-lock.json to 2.0.0\n` +
-      `${check} Npm run version\n`
-    );
-
-    expect(files.json("package.json")).to.deep.equal({ version: "2.0.0", scripts: { preversion: "echo preversion", version: "echo version", }});
-    expect(files.json("package-lock.json")).to.deep.equal({ version: "2.0.0" });
-  });
-
 });
diff --git a/test/specs/npm.spec.js b/test/specs/npm.spec.js
@@ -136,4 +136,28 @@ describe("npm version hooks", () => {
     expect(bin[6].version).to.equal("2.0.0");
   });
 
+  it("should skip whichever version scripts present", () => {
+    files.create("package.json", {
+      version: "1.2.3",
+      scripts: {
+        preversion: "echo preversion",
+        version: "echo version",
+      }
+    });
+    files.create("package-lock.json", { version: "1.2.3" });
+
+    let cli = bump("major --ignore-scripts");
+
+    expect(cli).to.have.stderr("");
+    expect(cli).to.have.exitCode(0);
+
+    expect(cli).to.have.stdout(
+      `${check} Updated package.json to 2.0.0\n` +
+      `${check} Updated package-lock.json to 2.0.0\n`
+    );
+
+    expect(files.json("package.json")).to.deep.equal({ version: "2.0.0", scripts: { preversion: "echo preversion", version: "echo version", }});
+    expect(files.json("package-lock.json")).to.deep.equal({ version: "2.0.0" });
+  });
+
 });