Skip to content

Commit

Permalink
Add a CBFS driver and commands to u-boot.
Browse files Browse the repository at this point in the history
This change adds CBFS support and some commands to use it to u-boot. These
commands are:

cbfsinit - Initialize CBFS support and pull all metadata into RAM. The end of
the ROM is an optional parameter which defaults to the standard 0xffffffff and
can be used to support multiple CBFSes in a system. The last one set up with
cbfsinit is the one that will be used.

cbfsinfo - Print information from the CBFS header.

cbfsls - Print out the size, type, and name of all the files in the current
CBFS. Recognized types are translated into symbolic names.

cbfsload - Load a file from CBFS into memory. Like the similar command for fat
filesystems, you can optionally provide a maximum size.

Support for CBFS is compiled in when the CONFIG_CMD_CBFS option is specified.

BUG=chrome-os-partner:3910
TEST=Built and booted on an Alex. Initialized with and without specifying the
end of the ROM, and with a bad end of ROM. Ran the commands before CBFS was
initialized. Ran cbfsinfo and saw reasonable output. Ran cbfsls and saw output
that matched what was printed when the CBFS was put together by the coreboot
ebuild. Used cbfsload to load a test text file into memory and verified that it
was the correct size and had the correct contents. Ran with a max size and saw
the file was truncated in memory.

Change-Id: I64d06d49633cef3cffac1d571519eae38c7d267f
Signed-off-by: Gabe Black <gabeblack@google.com>
Reviewed-on: http://gerrit.chromium.org/gerrit/4167
Reviewed-by: Gabe Black <gabeblack@chromium.org>
Tested-by: Gabe Black <gabeblack@chromium.org>
  • Loading branch information
Gabe Black committed Jul 16, 2011
1 parent 51656c8 commit 501eec6
Show file tree
Hide file tree
Showing 8 changed files with 525 additions and 3 deletions.
6 changes: 3 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -203,9 +203,9 @@ ifeq ($(CONFIG_OF_EMBED),y)
LIBS += dts/libdts.o
endif
LIBS += arch/$(ARCH)/lib/lib$(ARCH).o
LIBS += fs/cramfs/libcramfs.o fs/fat/libfat.o fs/fdos/libfdos.o fs/jffs2/libjffs2.o \
fs/reiserfs/libreiserfs.o fs/ext2/libext2fs.o fs/yaffs2/libyaffs2.o \
fs/ubifs/libubifs.o
LIBS += fs/cramfs/libcramfs.o fs/fat/libfat.o fs/fdos/libfdos.o \
fs/jffs2/libjffs2.o fs/reiserfs/libreiserfs.o fs/ext2/libext2fs.o \
fs/yaffs2/libyaffs2.o fs/ubifs/libubifs.o fs/cbfs/libcbfs.o
LIBS += net/libnet.o
LIBS += disk/libdisk.o
LIBS += drivers/bios_emulator/libatibiosemu.o
Expand Down
1 change: 1 addition & 0 deletions README
Original file line number Diff line number Diff line change
Expand Up @@ -629,6 +629,7 @@ The following options need to be configured:
CONFIG_CMD_BSP * Board specific commands
CONFIG_CMD_BOOTD bootd
CONFIG_CMD_CACHE * icache, dcache
CONFIG_CMD_CBFS * Support for coreboot's CBFS
CONFIG_CMD_CONSOLE coninfo
CONFIG_CMD_DATE * support for RTC, date/time...
CONFIG_CMD_DHCP * DHCP support
Expand Down
1 change: 1 addition & 0 deletions common/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ COBJS-$(CONFIG_ENV_IS_IN_EEPROM) += cmd_eeprom.o
COBJS-$(CONFIG_CMD_EEPROM) += cmd_eeprom.o
COBJS-$(CONFIG_CMD_ELF) += cmd_elf.o
COBJS-$(CONFIG_SYS_HUSH_PARSER) += cmd_exit.o
COBJS-$(CONFIG_CMD_CBFS) += cmd_cbfs.o
COBJS-$(CONFIG_CMD_EXT2) += cmd_ext2.o
COBJS-$(CONFIG_CMD_FAT) += cmd_fat.o
COBJS-$(CONFIG_CMD_FDC)$(CONFIG_CMD_FDOS) += cmd_fdc.o
Expand Down
118 changes: 118 additions & 0 deletions common/cmd_cbfs.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,118 @@
/*
* Copyright (c) 2011 The Chromium OS Authors. All rights reserved.
*
* See file CREDITS for list of people who contributed to this
* project.
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License as
* published by the Free Software Foundation; either version 2 of
* the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 59 Temple Place, Suite 330, Boston,
* MA 02111-1307 USA
*/

/*
* CBFS commands
*/
#include <common.h>
#include <command.h>
#include <cbfs.h>

int do_cbfs_init(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
{
uintptr_t end_of_rom = 0xffffffff;
char *ep;

if (argc > 2) {
printf("usage: cbfsls [end of rom]>\n");
return 0;
}
if (argc == 2) {
end_of_rom = (int)simple_strtoul(argv[1], &ep, 16);
if (*ep) {
puts("\n** Invalid end of ROM **\n");
return 1;
}
}
return file_cbfs_init(end_of_rom);
}

U_BOOT_CMD(
cbfsinit, 2, 0, do_cbfs_init,
"initialize the cbfs driver",
"[end of rom]\n"
" - Initialize the cbfs driver. The optional 'end of rom'\n"
" parameter specifies where the end of the ROM is that the\n"
" CBFS is in. It defaults to 0xFFFFFFFF\n"
);

int do_cbfs_fsload (cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
{
long size;
unsigned long offset;
unsigned long count;
char buf[12];

if (argc < 3) {
printf("usage: cbfsload <addr> <filename> [bytes]\n");
return 1;
}

/* parse offset and count */
offset = simple_strtoul(argv[1], NULL, 16);
if (argc == 4)
count = simple_strtoul(argv[3], NULL, 16);
else
count = 0;

size = file_cbfs_read(argv[2], (void *)offset, count);
if (size < 0) {
printf("\n** Unable to read \"%s\" from cbfs **\n", argv[2]);
return 1;
}

printf("\n%ld bytes read\n", size);

sprintf(buf, "%lX", size);
setenv("filesize", buf);

return 0;
}

U_BOOT_CMD(
cbfsload, 4, 0, do_cbfs_fsload,
"load binary file from a cbfs filesystem",
"<addr> <filename> [bytes]\n"
" - load binary file 'filename' from the cbfs to address 'addr'\n"
);

int do_cbfs_ls (cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
{
return file_cbfs_ls();
}

U_BOOT_CMD(
cbfsls, 1, 1, do_cbfs_ls,
"list files",
" - list the files in the cbfs\n"
);

int do_cbfs_fsinfo (cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
{
return file_cbfs_fsinfo();
}

U_BOOT_CMD(
cbfsinfo, 1, 1, do_cbfs_fsinfo,
"print information about filesystem",
" - print information about the cbfs filesystem\n"
);
1 change: 1 addition & 0 deletions fs/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
#

subdirs-$(CONFIG_CMD_CRAMFS) := cramfs
subdirs-$(CONFIG_CMD_CBFS) += cbfs
subdirs-$(CONFIG_CMD_EXT2) += ext2
subdirs-$(CONFIG_CMD_FAT) += fat
subdirs-$(CONFIG_CMD_FDOS) += fdos
Expand Down
44 changes: 44 additions & 0 deletions fs/cbfs/Makefile
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
#
# See file CREDITS for list of people who contributed to this
# project.
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License as
# published by the Free Software Foundation; either version 2 of
# the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
# MA 02111-1307 USA
#

include $(TOPDIR)/config.mk

LIB = $(obj)libcbfs.o

AOBJS =
COBJS-$(CONFIG_CMD_CBFS) := cbfs.o

SRCS := $(AOBJS:.o=.S) $(COBJS-y:.o=.c)
OBJS := $(addprefix $(obj),$(AOBJS) $(COBJS-y))

all: $(LIB) $(AOBJS)

$(LIB): $(obj).depend $(OBJS)
$(call cmd_link_o_target, $(OBJS))


#########################################################################

# defines $(obj).depend target
include $(SRCTREE)/rules.mk

sinclude $(obj).depend

#########################################################################
Loading

0 comments on commit 501eec6

Please sign in to comment.