Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Upgrade TCR's Go build version to 1.23 #781

Closed
28 tasks done
mengdaming opened this issue Sep 16, 2024 · 0 comments · Fixed by #785
Closed
28 tasks done

[Feature]: Upgrade TCR's Go build version to 1.23 #781

mengdaming opened this issue Sep 16, 2024 · 0 comments · Fixed by #785
Assignees
@mengdaming
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code go Pull requests that update Go code S Small

Comments

@mengdaming
Copy link
Contributor

mengdaming commented Sep 16, 2024 •
edited
Loading

Contact Details

damien.menanteau@gmail.com

Feature Request

TCR is currently built with Go 1.22, while version 1.23 is now available.

Feature Description

Upgrade go version in tcr module from 1.22 to 1.23.

We should check in particular that:

All existing toolchains still work as before
All GitHub actions work properly

Alternatives

Stick to Go 1.22

Additional Context

Go 1.23 release notes: https://go.dev/doc/go1.23

Code of Conduct

  • I agree to follow this project's Code of Conduct

To Do List

  • Upgrade go version to 1.23
    • Change go version to 1.23 in go modules
      • src/go.mod (tcr module)
      • tcr-doc/go.mod (tcr doc generation)
      • go.work
    • Change go version in GitHub actions
      • .github/workflows/go.yml
      • .github/workflows/golangci_lint.yml
      • .github/workflows/goreleaser.yml
    • Verify that the 3 steps pass on GitHub
      • Check build
      • Check lint
      • Check release (can only be done after changes are merged on main branch)
    • Update the development documentation
      • dev-doc/build.md
    • Update .golangci.yml
    • Update examples with go language
      • examples/go.work
      • examples/go-bazel/go.mod
      • examples/go-go-tools/go.mod
      • examples/go-gotestsum/go.mod
      • examples/go-make/go.mod
  • Test that there is no regression
    • Verify that build works
    • Verify that tests work
    • Verify that linter doesn't raise any problems
    • Test that new version works with all existing toolchain (cf. script tools/tcr/verify-tcr-examples.sh)
@mengdaming mengdaming added enhancement New feature or request go Pull requests that update Go code labels Sep 16, 2024
@mengdaming mengdaming added github_actions Pull requests that update GitHub Actions code S Small labels Sep 16, 2024
@mengdaming mengdaming self-assigned this Sep 24, 2024
mengdaming added a commit that referenced this issue Sep 24, 2024
@mengdaming
[#781] Bump go version from 1.22.6 to 1.23.1
c652e07
@mengdaming mengdaming mentioned this issue Sep 24, 2024
Merged
6 tasks
@mengdaming mengdaming linked a pull request Sep 24, 2024 that will close this issue
[#781] Bump go version from 1.22.6 to 1.23.1 #785
Merged
6 tasks
mengdaming added a commit that referenced this issue Sep 25, 2024
@mengdaming
[#781] Fix test cases on timer (ticking counts after timeout)
8a050c6 
- these tests were incorrectly asserting the number of ticks
- Go 1.23 introduces enhancements on timers and tickers
- Upgrading to 1.23 made the above errors apparent
@github-project-automation github-project-automation bot moved this from Review in progress to Done in TCR Enhancements & Bugs Follow Up Oct 1, 2024
mengdaming added a commit that referenced this issue Oct 1, 2024
@mengdaming
[#781] Fix addtional test case on timer (ticking counts after timeout)
ccc20cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mengdaming mengdaming

Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code go Pull requests that update Go code S Small
Projects
TCR Enhancements & Bugs Follow Up
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refs/heads/781-tcr-1.23 murex/TCR
[#781] Bump go version from 1.22.6 to 1.23.1 murex/TCR
1 participant
@mengdaming