Security ssh detection update #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added separate run for ssh group detection.
Removed user verbiage for ssh_group output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current SSH information in the Client Details and Security Listing doesn't include group or directory based users.
The changes I incorporated gather user and group information from the com.apple.ssh_access group.
Users that are explicitly added in the Remote Login Preference pane are listed in the GroupMemberships key.
Groups are a little trickier as they are only stored as UUIDs. Using a couple loops those UUIDs can be converted to group names.
Since groups are now supported I thought it didn't make much sense to use the previous method of evaluating each local user against the com.apple.ssh_access list to check if they are members. That method won't catch directory based groups would not list all of it's members as SSH Users.
Since this is my first go at a v3 migration I'd appreciate a keen eye on how the migration is performed. In testing the current code appears to work fine.