Fix printer.py to handle when sharing is off #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bochoven
added a commit
that referenced
this pull request
Feb 20, 2016
Fix printer.py to handle when sharing is off
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As promised the Printer script fixed. No longer shall the preflight script exit 1.
I got a little lazy and only tested in 10.6, 10.7, 10.9 and 10.11. Even if 10.8 and 10.10 are different the exception for KeyError should cover us.
The 'shared' key is better as it is present on 10.6-10.11 while the 'printersharing' key was only on later OS releases.
Also linted the script while it was open.