Assorted documentation updates #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- document worst, worstid, ofields, fofields, and num*fields vars - don't need | or > in the notification commands anymore, or to repeat the command twice - explain how commands are (sometimes) run with sh -c and warn abou the importance of correct escaping in that case - mention that \t and \n can be used in alert messages
Pull Request Test Coverage Report for Build 2651
💛 - Coveralls |
sumpfralle
approved these changes
Mar 27, 2019
There was a problem hiding this comment.
Wow - what a huge improvement!
Thank you a lot for taking the time to improve these long neglected parts of the documentation!
I added two comments/nitpicks below - feel free to amend/force-push the pull request.
But you should better be quick - I want to merge these great improvements right now :)
- multigraph blocks can't be interleaved in the "fetch" output - multigraph plugins can be used for heterogenous top-level graphs as well as for graph heirarchies
- clean up and organize tutorial/snmp, and add information about manually enabling SNMP plugins - add information about writing remote monitoring plugins to develop/plugins/advanced-topics - add links to these pages to plugin/snmp
ToxicFrog
force-pushed
the
documentation
branch
from
0ed95ac to
a8c5dae
Compare
|
Done! Fixed some other misspellings I introduced while I was there. |
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.