Skip to content

πŸ‘¨β€πŸ’» Simplify the workflow for running ty - #257

Merged
burgholzer merged 3 commits into
mainfrom
simplify-running-ty
Nov 28, 2025
Merged

πŸ‘¨β€πŸ’» Simplify the workflow for running ty#257
burgholzer merged 3 commits into
mainfrom
simplify-running-ty

Conversation

@burgholzer

Copy link
Copy Markdown
Member

Description

Another small improvement for how ty is being run based on the experience gained when rolling this support out across repositories.

Checklist:

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • I have added entries to the changelog for any noteworthy additions, changes, fixes, or removals.
  • I have added migration instructions to the upgrade guide (if needed).
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer self-assigned this Nov 28, 2025
@burgholzer burgholzer added continuous integration Anything related to the CI setup python Anything related to Python code usability Anything related to usability labels Nov 28, 2025
Signed-off-by: burgholzer <burgholzer@me.com>

@denialhaag denialhaag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@burgholzer

Copy link
Copy Markdown
Member Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Nov 28, 2025

Copy link
Copy Markdown
Contributor
βœ… Actions performed

Full review triggered.

@coderabbitai

coderabbitai Bot commented Nov 28, 2025

Copy link
Copy Markdown
Contributor
πŸ“ Walkthrough

Summary by CodeRabbit

  • Chores
    • Streamlined CI/CD workflow for type-checking processes
  • Documentation
    • Updated changelog documenting workflow improvements

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

Remove redundant UV setup options and simplify the ty type-check step in the GitHub Actions Python linter workflow; add an Unreleased changelog entry documenting this change.

Changes

Cohort / File(s) Summary
Workflow simplification
/.github/workflows/reusable-python-linter.yml
Removed python-version and activate-environment from the UV setup step; replaced the multi-command shell block for running ty with a single uv run --no-sync ty check invocation.
Changelog update
CHANGELOG.md
Added an "Unreleased" entry describing the workflow simplification and added a PR reference link.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Focus review on the modified workflow step for correctness of the new uv command and any required flags.
  • Verify changelog entry formatting and PR link.

Possibly related PRs

Poem

🐰
I nibbled through the workflow tree,
Trimmed extra hops so ty runs free.
One swift command, the path made light,
A cleaner hop β€” and all feels right. ✨

Pre-merge checks and finishing touches

βœ… Passed checks (3 passed)
Check name Status Explanation
Title check βœ… Passed The title clearly and specifically describes the main change: simplifying the workflow for running the ty tool, which aligns with the primary modifications shown in the changeset.
Description check βœ… Passed The description provides context about the improvement, confirms all checklist items are completed, and aligns with the template structure, though it lacks specific issue references or detailed technical context.
Docstring Coverage βœ… Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
πŸ§ͺ Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch simplify-running-ty

πŸ“œ Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 93af7bb and c1a2a6e.

πŸ“’ Files selected for processing (1)
  • .github/workflows/reusable-python-linter.yml (1 hunks)
πŸ”‡ Additional comments (1)
.github/workflows/reusable-python-linter.yml (1)

58-62: The implementation correctly uses the two-step approach to balance type-checking accuracy with build speed.

The ty check step properly combines uv sync --no-install-project (which installs all dependencies including dev groups) with uv run --no-sync ty check (which runs ty without re-syncing). This ensures ty has access to project dependencies for accurate type checking while avoiding the overhead of installing the project itself.

Both flags are well-established:

  • --no-install-project available since uv 0.3.3
  • --no-sync available in uv 0.4.x and later

Since setup-uv v7.1.4 installs the latest uv by default, compatibility is not a concern. The implementation is sound and ready.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

πŸ“œ Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 20b91b0 and 93af7bb.

πŸ“’ Files selected for processing (2)
  • .github/workflows/reusable-python-linter.yml (1 hunks)
  • CHANGELOG.md (2 hunks)
πŸ”‡ Additional comments (1)
CHANGELOG.md (1)

12-14: LGTM! Changelog entry and PR link are properly formatted.

The "Changed" entry accurately reflects the workflow simplification and follows the established format. The PR link is correctly positioned in the PR links section.

Also applies to: 202-202

Comment thread .github/workflows/reusable-python-linter.yml Outdated
Signed-off-by: burgholzer <burgholzer@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

continuous integration Anything related to the CI setup python Anything related to Python code usability Anything related to usability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants