Conversation
burgholzer
approved these changes
May 28, 2025
burgholzer
left a comment
Member
There was a problem hiding this comment.
LGTM 👍🏻
Just to be on the safe side here: could you introduce a dummy change (comment in one of the lines) for the cd.yml file so that the corresponding workflows are triggered here.
Once they pass, revert the change, enable auto-merge for this PR and, after it is merged, create a release.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ystade
commented
May 28, 2025
Signed-off-by: Yannick Stade <100073938+ystade@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since the addition of the Zoned Neutral Atom Compiler the CD keeps to fail even though all tests succeed. The issue seems to be related to the serialization of
chrono::micorseconds. On many systems, this serialization is not defined and was manually defined ininclude/na/zoned/Compiler.hpp. Apparently, on the Linux systems used for building the wheels, this serialization function is already defined. To circumvent this issue, the type of the members in the statistics structure was changed toint64_treturned bychrono::micorseconds::count(), and the serialization was removed.Additionally, this PR prepares the next patch release.
Checklist: