Skip to content

🐛 Fix CD - #661

Merged
ystade merged 5 commits into
mainfrom
fix-cd
May 28, 2025
Merged

🐛 Fix CD#661
ystade merged 5 commits into
mainfrom
fix-cd

Conversation

@ystade

@ystade ystade commented May 28, 2025

Copy link
Copy Markdown
Collaborator

Description

Since the addition of the Zoned Neutral Atom Compiler the CD keeps to fail even though all tests succeed. The issue seems to be related to the serialization of chrono::micorseconds. On many systems, this serialization is not defined and was manually defined in include/na/zoned/Compiler.hpp. Apparently, on the Linux systems used for building the wheels, this serialization function is already defined. To circumvent this issue, the type of the members in the statistics structure was changed to int64_t returned by chrono::micorseconds::count(), and the serialization was removed.

Additionally, this PR prepares the next patch release.

Checklist:

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • I have added entries to the changelog for any noteworthy additions, changes, fixes or removals.
  • I have added migration instructions to the upgrade guide (if needed).
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

@ystade ystade self-assigned this May 28, 2025
@ystade ystade added the documentation Improvements or additions to documentation label May 28, 2025
@ystade ystade added packaging Anything related to Python packaging fix Anything related to bugfixes extensive-python-ci Adding this label indicates that extensive Python CI runs should be started for this PR. labels May 28, 2025
@github-project-automation github-project-automation Bot moved this to In Progress in MQT Compilation May 28, 2025
@ystade
ystade requested a review from burgholzer May 28, 2025 08:34

@burgholzer burgholzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Just to be on the safe side here: could you introduce a dummy change (comment in one of the lines) for the cd.yml file so that the corresponding workflows are triggered here.
Once they pass, revert the change, enable auto-merge for this PR and, after it is merged, create a release.

@codecov

codecov Bot commented May 28, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@burgholzer burgholzer added the continuous integration Anything related to the CI setup label May 28, 2025
Comment thread .github/workflows/cd.yml Outdated
ystade added 2 commits May 28, 2025 13:22
Signed-off-by: Yannick Stade <100073938+ystade@users.noreply.github.com>
@ystade
ystade enabled auto-merge (squash) May 28, 2025 11:25
@ystade
ystade merged commit 14df9c9 into main May 28, 2025
@ystade
ystade deleted the fix-cd branch May 28, 2025 12:52
@github-project-automation github-project-automation Bot moved this from In Progress to Done in MQT Compilation May 28, 2025
@coderabbitai coderabbitai Bot mentioned this pull request Oct 15, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

continuous integration Anything related to the CI setup documentation Improvements or additions to documentation extensive-python-ci Adding this label indicates that extensive Python CI runs should be started for this PR. fix Anything related to bugfixes packaging Anything related to Python packaging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants