💥 Remove the neutral-atom stack - #2137
Merged
Merged
Conversation
Assisted-by: Opus 5 via Claude Code
Assisted-by: Opus 5 via Claude Code
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Assisted-by: Opus 5 via Claude Code
Assisted-by: Opus 5 via Claude Code
12 tasks
Assisted-by: Opus 5 via Claude Code
denialhaag
force-pushed
the
remove-na-stack
branch
from
August 17, 2026 20:04
671c20d to
fb8eb17
Compare
burgholzer
approved these changes
Aug 17, 2026
burgholzer
left a comment
Member
There was a problem hiding this comment.
Nice work 👍🏼
The integration on the other side is likely a bit more cumbersome, but I think we can already move along with this 👍🏼
Member
Author
Yeah, I think the other side will be much more involved, but I agree that we can merge here. 😌 |
12 tasks
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
🤖 AI text below 🤖
MQT Core no longer contains any neutral-atom functionality. MQT QMAP is now its sole owner and absorbs the transferred code in munich-quantum-toolkit/qmap#1111.
This removes the neutral-atom computation model (
MQT::CoreNA), the neutral-atom FoMaC device session, the neutral-atom QDMI device together with its runtime configuration parser and device schema, themqt.core.naPython module, andAodOperation. It also drops theMove,Bridge,AodActivate,AodDeactivate, andAodMoveoperation kinds from the closedqc::OpTypeenum, along with the OpenQASM names they dumped and parsed,QuantumComputation::bridge, and theBUILD_MQT_CORE_QDMI_NA_DEVICEoption. The bundledmqt.na.defaultQDMI device is no longer registered.UPGRADING.mdlists every removed name.Several tests used the neutral-atom device merely as a stand-in for some device rather than for anything neutral-atom-specific. The QDMI driver, device-ownership, and Python QDMI tests now use the superconducting device instead. Because the superconducting device is a circuit-model device, the ownership test that asserted a site is a zone now asserts the opposite.
Three tests covered the rejection of zone-model devices at the circuit-target boundary:
CompilerQDMIAdapterTest.RejectsNeutralAtomZoneModels,test_compiler_target_rejects_qdmi_zone_model, andtest_zoned_operation_rejected_at_backend_init. The rejection logic stays and still guards external zone-model devices, but MQT Core no longer bundles a device that exercises it, so these tests are removed. MQT QMAP is the natural home for them once it owns the device.Fixes #2092
AI notice
This PR and its contents were created with the assistance of Opus 5 via Claude Code.
Checklist
If PR contains AI-assisted content:
🤖 *AI text below* 🤖(titles are exempt).