Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Julia Haas <83269984+juleshaas@users.noreply.github.com>
  • Loading branch information
anikaweinmann and juleshaas authored Feb 20, 2024
1 parent 8f3c9a8 commit 1800573
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions src/grass_gis_helpers/data_import.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
from .raster import adjust_raster_resolution, rename_raster


def downloaad_and_import_tindex(tindex_url, output, download_dir):
def download_and_import_tindex(tindex_url, output, download_dir):
"""Download and import tile index from url
Args:
Expand Down Expand Up @@ -337,8 +337,8 @@ def import_local_xyz_files(
local_data_dir,
all_raster,
):
"""Import local XYZ raster data. Where the XYZ files which are inside the
directory of "local_data_dir", will be imported for the AOI.
"""Import local XYZ raster data. XYZ files which are inside the
directory of "local_data_dir" will be imported for the AOI.
Args:
aoi (str): Vector map with area of interest
Expand Down Expand Up @@ -385,7 +385,7 @@ def import_local_xyz_files(
grass.message(
_(f"XYZ file <{os.path.basename(xyz_file)}> imported.")
)
# check if raster where imported
# check if raster were imported
if len(all_raster) > 0:
imported_local_data = True
return imported_local_data
6 changes: 3 additions & 3 deletions src/grass_gis_helpers/open_geodata_germany/download_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@


def check_download_dir(download_dir):
"""Checks if download directory is set. If yes check if folder exists or
creating it. If not set a temporary directory
"""Checks if download directory is set. If yes, checks if folder exists or
creates it. If not set, a temporary directory will be used.
Args:
download_dir (str): download directory module parameter
Expand Down Expand Up @@ -76,7 +76,7 @@ def download_data_using_threadpool(urls, download_dir, nprocs):
Args:
urls (list): List with data download urls
download_dir (str): Path to directory where the data should be
downloaded
downloaded to
nprocs (int): The number of worker threads to use; If processes is None
then the number returned by os.cpu_count() is used.
"""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@


def get_federal_states(federal_state, federal_state_file):
"""Get federale state and federal state file module parameters and return
"""Get federal state and federal state file module parameters and return
list with federal state abbrevations
Args:
Expand Down

0 comments on commit 1800573

Please sign in to comment.