Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract mun_hir_input #571

Merged
merged 4 commits into from
Jul 30, 2024

Conversation

baszalmstra
Copy link
Collaborator

Extracts the input part of the hir database into its own seperate crate: mun_hir_input.

The goals is to create a cleaner API separation and at the same time decrease incremental compilation time by splitting crates.

@baszalmstra baszalmstra requested a review from Wodann July 17, 2024 09:27
@baszalmstra baszalmstra force-pushed the refactor/extract_mun_hir_input branch from 9598913 to a3eb9f8 Compare July 17, 2024 13:22
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 94.35484% with 7 lines in your changes missing coverage. Please review.

Project coverage is 87.40%. Comparing base (cf1bae3) to head (282fed4).

Files Patch % Lines
crates/mun_codegen/src/mock.rs 66.66% 1 Missing ⚠️
crates/mun_codegen/src/module_group.rs 0.00% 1 Missing ⚠️
crates/mun_compiler/src/db.rs 50.00% 1 Missing ⚠️
crates/mun_hir_input/src/module_tree.rs 83.33% 1 Missing ⚠️
crates/mun_hir_input/src/package_set.rs 0.00% 1 Missing ⚠️
crates/mun_language_server/src/analysis.rs 80.00% 1 Missing ⚠️
crates/mun_language_server/src/db.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #571   +/-   ##
=======================================
  Coverage   87.40%   87.40%           
=======================================
  Files         274      276    +2     
  Lines       32543    32531   -12     
=======================================
- Hits        28444    28434   -10     
+ Misses       4099     4097    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Wodann Wodann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments but feel free to address them and merge yourself.

@baszalmstra baszalmstra merged commit 7c7a3c7 into mun-lang:main Jul 30, 2024
18 checks passed
@baszalmstra baszalmstra deleted the refactor/extract_mun_hir_input branch July 30, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants