improvement(memory): full support for struct memory mapping #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
==========================================
+ Coverage 82.87% 82.94% +0.07%
==========================================
Files 163 163
Lines 11269 11509 +240
==========================================
+ Hits 9339 9546 +207
- Misses 1930 1963 +33
Continue to review full report at Codecov.
|
Wodann
force-pushed
the
improvement/struct-mapping
branch
from
c98364b
to
6fefc2c
Compare
baszalmstra
approved these changes
May 12, 2020
|
I've added a commit that resolves your comment. Could you please review it @baszalmstra? |
Wodann
force-pushed
the
improvement/struct-mapping
branch
2 times, most recently
from
6217ca6
to
b7fcf06
Compare
baszalmstra
approved these changes
May 13, 2020
as memory mapping requires knowledge about a struct's memory kind, this
needed to be added to one of the memory::Type{..} traits. TypeLayout
seemed most applicable
this also fixes "identity" memory mapping, where only an old type pointer needed to be replaced with a new pointer to the same type information
Wodann
force-pushed
the
improvement/struct-mapping
branch
from
b7fcf06
to
8a4e9b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to previous available struct memory mapping, this PR adds:
gc -> gc,gc -> value,value -> value,value -> gcstructs of the same typegc -> gc,gc -> value,value -> value,value -> gcstructs of the different typesIt also fixes a bug with "identity" memory mapping; i.e. when only an old type pointer needed to be replaced with a new pointer to the same type information, instead of actually mapping memory.