Update buildenv/1.3.x/win32-static's protobuf to 3.2.0 #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkrautz
force-pushed
the
update-protobuf
branch
from
e85c240 to
6ca1758
Compare
mkrautz
force-pushed
the
update-protobuf
branch
from
6ca1758 to
073ff08
Compare
mkrautz
changed the title
|
I updated the PR and merged it, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified the patch
protobuf-2.5.0-win32-disable-OutputDirectoryIsFileError-test.patchis still necessary as the testCommandLineInterfaceTest, OutputDirectoryIsFileErrorotherwise fails.Not sure if the
_SILENCE_STDEXT_HASH_DEPRECATION_WARNINGSdefine is still necessary. Was in the prop file before, would need to be added to the nmake invoke now.Upgrading protobuf does not fix my #44 issue.
No change to 1.2.x.