Make using 1.3.x/win32-static/setup/prep.cmd easier to use in scripts #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkrautz
suggested changes
Feb 5, 2017
|
@mkrautz PTAL . I adjusted the shortcut generation to make cygwin no longer rely on the nested shell. |
With this patch we no longer open a child cmd.exe a script that wants to call prep.cmd would get stuck in. It also removes a pause on error and instead exits with an error code.
|
LGTM. Works for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch we no longer open a child cmd.exe a
script that wants to call prep.cmd would get stuck in.
It also removes a pause on error and instead exits with
an error code.