Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cygwin-bootstrap in buildenv/1.3.x/win32-static. #35

Merged
merged 2 commits into from
Mar 26, 2017

Conversation

mkrautz
Copy link
Contributor

@mkrautz mkrautz commented Jan 8, 2017

This pull request updates the buildenv/1.3.x/win32-static buildenv to install its own copy of Cygwin, instead of relying on the user to do so.

Since we mirror the Cygwin installation files ourselves, this means that we now ensure that all users of a particular buildenv use the same Cygwin version -- which is great for ensuring stability and reproducibility of bugs.

@mkrautz mkrautz force-pushed the cygwin-bootstrap-v2 branch 2 times, most recently from 60f440d to d6012d9 Compare January 8, 2017 22:45
@mkrautz mkrautz mentioned this pull request Jan 9, 2017
@Kissaki
Copy link
Member

Kissaki commented Jan 9, 2017

The commit should explain what it solves - as described in #9

Copy link
Member

@Kissaki Kissaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the missing commit message about what advantages this change brings, LGTM.
Did not execute, only read the diff.

From #9 I would have expected some python code that this replaces to be dropped??

@mkrautz
Copy link
Contributor Author

mkrautz commented Jan 9, 2017

@Kissaki Thanks for the review.

Issue #9 talks about a Python version that's linked from within #9 - it is/was a WIP, never really ready to merge, only served as a proof-of-concept.

I'll add some more docs to the commit...

@mkrautz
Copy link
Contributor Author

mkrautz commented Jan 9, 2017

Letting this sit until I can verify a full build actually works. :-)

@mkrautz mkrautz force-pushed the cygwin-bootstrap-v2 branch 3 times, most recently from 717ed6b to 6439cd0 Compare March 26, 2017 11:10
@mkrautz mkrautz force-pushed the cygwin-bootstrap-v2 branch from 6439cd0 to 8f22294 Compare March 26, 2017 11:16
@mkrautz mkrautz merged commit 3ee0bc1 into mumble-voip:master Mar 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants