Fixed issue with reset callback#46
Merged
arhtudormorar merged 3 commits intodevelopmentfrom Feb 6, 2026
Merged
Conversation
arhtudormorar
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resetStateCallbackis stored, invoked reliably on reset, and the provider can be re-initialized correctly.3.2.7-alpha.18.Changes
resetStateCallbackon the instance instead of wiring it directly through the constructor.setupResetStateListenerthat:resetStateResponse.finalizeResetState()when the reset response is received.resetStateCallbackafter finalizing the reset.initializedtofalseso a new handshake can occur cleanly.initializedstate).finalizeHandshakeResponse, mark the provider as initialized and only then set up the reset listener when aresetStateCallbackis present.package.jsonversion to3.2.7-alpha.18.publish-verdaccioscript for local publishing.Rationale
finalizeResetState, which could cause race conditions and unreliable reset behavior.finalizeResetState, making the lifecycle easier to reason about and debug.Testing
finalizeResetStateis called once per reset.resetStateCallbackis invoked exactly once.initializedbecomesfalseafter reset and a subsequent handshake works correctly.