Rc/v3.0.1.5 #972
Draft
Rc/v3.0.1.5 #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All xMex fees to users
Coverage SummaryTotals
FilesExpand
|
|
Contract comparison - from 79c6016 to 78df98b
|
…okens Disable add liquidity for locked tokens
change undistributed rewards code
psorinionut
reviewed
Nov 15, 2024
|
|
||
| #[view(isAddLiqDisabled)] | ||
| #[storage_mapper("addLiqDisabled")] | ||
| fn add_liq_disabled(&self) -> SingleValueMapper<bool>; |
There was a problem hiding this comment.
Even though we want to have it disabled, we shouldn't name the storage in a negative manner. I would suggest add_liq_enabled -> and set it to false. It is more clear this way. Also, this way the default would still be disabled, if the storage is empty.
There was a problem hiding this comment.
Alright then. Currently working on something else, will do after.
| second_token_id: TokenIdentifier, | ||
| second_token_amount_desired: BigUint, | ||
| second_token_amount_min: BigUint, | ||
| args: CallAddLiqArgs<Self::Api>, |
There was a problem hiding this comment.
I know this is way cleaner at a SC level, but isn't it more difficult for the one calling/integrating this endpoint? As he needs to also encode the struct, instead of just providing each element.
There was a problem hiding this comment.
Nope, this isn't an endpoint, it's an internal function.
There was a problem hiding this comment.
Indeed, you are right.
additional tests for add liq disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.