Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hooks definition #818

Merged
merged 2 commits into from
Jan 29, 2024
Merged

hooks definition #818

merged 2 commits into from
Jan 29, 2024

Conversation

dorin-iancu
Copy link
Contributor

First draft of hooks.

hook.dest_address,
hook.endpoint_name,
)
.with_raw_arguments(call_args.clone())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the arguments should belong to Hook structure. At each call you are passing the same arguments.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, I store the "Hook" in storage, so it needs to be as small as possible.

@dorin-iancu dorin-iancu marked this pull request as ready for review January 29, 2024 06:52
Base automatically changed from cleanup-pair to main January 29, 2024 07:48
Copy link

Contract comparison - from 59b5cf6 to 0139977

Path                                                                                             size                  has-allocator                     has-format
mx-exchange-sc
- pause-all/pause-all.wasm 5548 No No
mx-exchange-sc/dex
- farm/farm.wasm 38759 No No
- farm-with-locked-rewards/farm-with-locked-rewards.wasm 38439 No No
- governance/governance.wasm 17355 No No
- pair
- - pair.wasm 31112 ➡️ 33409 🔴 No No
- - pair-full.wasm 32518 ➡️ 34802 🔴 No No
- - safe-price-view.wasm 7888 No No
- pair-mock/pair-mock.wasm 5470 No No
- price-discovery/price-discovery.wasm 16381 No No
- proxy-deployer/proxy-deployer.wasm 4502 No No
- router/router.wasm 26718 No No
mx-exchange-sc/energy-integration
- energy-factory-mock/energy-factory-mock.wasm 4277 No No
- energy-update/energy-update.wasm 1558 No No
- fees-collector/fees-collector.wasm 18953 No No
- governance-v2/governance-v2.wasm 16607 No No
mx-exchange-sc/farm-staking
- farm-staking/farm-staking.wasm 43079 No No
- farm-staking-proxy/farm-staking-proxy.wasm 19393 No No
- metabonding-staking/metabonding-staking.wasm 10176 No No
mx-exchange-sc/locked-asset
- distribution/distribution.wasm 14292 No No
- energy-factory/energy-factory.wasm 35029 No No
- factory/factory.wasm 30471 No No
- lkmex-transfer/lkmex-transfer.wasm 11288 No No
- locked-token-wrapper/locked-token-wrapper.wasm 14586 No No
- proxy_dex/proxy_dex.wasm 36917 No No
- simple-lock/simple-lock.wasm 24491 No No
- simple-lock-whitelist/simple-lock-whitelist.wasm 26210 No No
- token-unstake/token-unstake.wasm 14288 No No

@dorin-iancu dorin-iancu merged commit e396169 into main Jan 29, 2024
4 checks passed
@dorin-iancu dorin-iancu deleted the hooks branch January 29, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants