New farm refactor #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasurobert
reviewed
May 17, 2021
| @@ -175,6 +182,10 @@ pub trait Farm: | |||
| "Cannot exit farm with 0 entering amount" | |||
| ); | |||
|
|
|||
| // Before removing liquidity, first generate the rewards. | |||
| let reward_token_id = self.reward_token_id().get(); | |||
There was a problem hiding this comment.
so here was a logical issue, not ?
There was a problem hiding this comment.
Can you add a unit test ?
There was a problem hiding this comment.
Not a logical issue. There is a test for this, but tests reside inside arwen repo, at least atm
sasurobert
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.