Skip to content

Feat/supernova async exec #7055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 109 commits into
base: rc/supernova
Choose a base branch
from
Draft

Conversation

AdoAdoAdo
Copy link
Contributor

@AdoAdoAdo AdoAdoAdo commented Jun 17, 2025

Reasoning behind the pull request

The processing in Supernova decouples from consensus, happening in parallel.
This feat will hold all the processing changes to cover the decoupling, together with the changes in the proposal, proposal verification and processing flows.
The execution will unify part of the proposer and regular validators/observers processing logic.

Proposed changes

  • Block proposal before execution
  • Verification of the proposal logic change
  • Regarding execution results verification, cover notarized execution results
  • Component for estimating when an execution result can be included on the proposed block
  • Processing queue - for proposed blocks
  • Tracking of execution results and notifying the txpool of new selection context
  • Selection of transactions from txpool with adaptive bandwidth
  • Changed block processing time boundaries - can extend to the full round time, and can even extend beyond it

Testing procedure

  • txgen scenarios
  • performance testing & analysis vs Spica - performance analysis framework with record-replay txgen scenarios
  • chain simulator tests
  • full automated functional testing & system tests
  • reset tests
  • upgrade test
  • backwards compatibility (importDB) tests

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

Copy link

Integration Tests completed with failures or errors.

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: d7e16b882fc3fcc99d46a53633d9bc3bfcde8ffe
  • Current Branch: feat/supernova-async-exec
  • mx-chain-go Target Branch: rc/supernova
  • mx-chain-simulator-go Target Branch: rc/supernova
  • mx-chain-testing-suite Target Branch: rc/supernova
  • mx-chain-simulator-go Commit Hash: 9f1a71433bae347a5efe00e47b9c667f4d7693d4

🚀 Environment Variables:

  • TIMESTAMP: 2025_JUNE_24__10_43_28
  • PYTEST_EXIT_CODE: 1

Copy link

codecov bot commented Jun 24, 2025

Codecov Report

❌ Patch coverage is 91.73364% with 72 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.20%. Comparing base (cfd03c5) to head (d2aac5d).
⚠️ Report is 2 commits behind head on rc/supernova.

Files with missing lines Patch % Lines
process/block/preprocess/basePreProcess.go 39.28% 11 Missing and 6 partials ⚠️
process/executionTrack/executionResultsTracker.go 91.01% 10 Missing and 5 partials ⚠️
process/block/preprocess/transactions.go 63.63% 6 Missing and 2 partials ⚠️
common/common.go 91.66% 6 Missing and 1 partial ⚠️
process/block/mbsSelectionSession.go 96.70% 4 Missing and 2 partials ⚠️
process/block/preprocess/rewardTxPreProcessor.go 73.68% 3 Missing and 2 partials ⚠️
process/block/preprocess/smartContractResults.go 72.22% 3 Missing and 2 partials ⚠️
...cess/block/preprocess/validatorInfoPreProcessor.go 60.00% 3 Missing and 1 partial ⚠️
consensus/spos/bls/v2/subroundBlock.go 76.92% 2 Missing and 1 partial ⚠️
process/block/preprocess/txsForBlock.go 98.75% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           rc/supernova    #7055      +/-   ##
================================================
+ Coverage         75.11%   75.20%   +0.09%     
================================================
  Files               823      829       +6     
  Lines            135092   135690     +598     
================================================
+ Hits             101473   102048     +575     
- Misses            27892    27902      +10     
- Partials           5727     5740      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Integration Tests passed successfully!

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: dcad784d15710517057597c2f17eb18d292ddf0c
  • Current Branch: feat/supernova-async-exec
  • mx-chain-go Target Branch: rc/supernova
  • mx-chain-simulator-go Target Branch: rc/supernova
  • mx-chain-testing-suite Target Branch: rc/supernova
  • mx-chain-simulator-go Commit Hash: 9f1a71433bae347a5efe00e47b9c667f4d7693d4

🚀 Environment Variables:

  • TIMESTAMP: 2025_JUNE_26__10_34_00
  • PYTEST_EXIT_CODE: 0

Copy link

Integration Tests completed with failures or errors.

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: cc93c41f65240d9b1387fb9f2cb8b56166bddeec
  • Current Branch: feat/supernova-async-exec
  • mx-chain-go Target Branch: rc/supernova
  • mx-chain-simulator-go Target Branch: rc/supernova
  • mx-chain-testing-suite Target Branch: rc/supernova
  • mx-chain-simulator-go Commit Hash: 9f1a71433bae347a5efe00e47b9c667f4d7693d4

🚀 Environment Variables:

  • TIMESTAMP: 2025_JULY_15__12_11_41
  • PYTEST_EXIT_CODE: ``

Copy link

Integration Tests completed with failures or errors.

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: b78a239ba591e7530fb31d4bf7fb5268defb33d9
  • Current Branch: feat/supernova-async-exec
  • mx-chain-go Target Branch: rc/supernova
  • mx-chain-simulator-go Target Branch: rc/supernova
  • mx-chain-testing-suite Target Branch: rc/supernova
  • mx-chain-simulator-go Commit Hash: 9f1a71433bae347a5efe00e47b9c667f4d7693d4

🚀 Environment Variables:

  • TIMESTAMP: 2025_JULY_16__09_52_11
  • PYTEST_EXIT_CODE: ``

Copy link

Integration Tests completed with failures or errors.

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: e3e17f3581aff17c6ea8ef84af2b4f41e9d58db2
  • Current Branch: feat/supernova-async-exec
  • mx-chain-go Target Branch: rc/supernova
  • mx-chain-simulator-go Target Branch: rc/supernova
  • mx-chain-testing-suite Target Branch: rc/supernova
  • mx-chain-simulator-go Commit Hash: 9f1a71433bae347a5efe00e47b9c667f4d7693d4

🚀 Environment Variables:

  • TIMESTAMP: 2025_JULY_30__08_44_19
  • PYTEST_EXIT_CODE: ``

Copy link

Integration Tests passed successfully!

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: d2aac5d750ca9e24c2dac1978da3d89e0423dfdd
  • Current Branch: feat/supernova-async-exec
  • mx-chain-go Target Branch: rc/supernova
  • mx-chain-simulator-go Target Branch: rc/supernova
  • mx-chain-testing-suite Target Branch: rc/supernova
  • mx-chain-simulator-go Commit Hash: 9f1a71433bae347a5efe00e47b9c667f4d7693d4

🚀 Environment Variables:

  • TIMESTAMP: 2025_JULY_31__12_19_16
  • PYTEST_EXIT_CODE: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants