Skip to content

Conversation

@patrikjuvonen
Copy link
Contributor

@patrikjuvonen patrikjuvonen commented Apr 27, 2019

Summary

Tests

Validation

To help validate the integrity of the update I have created the following bash script that diffs between my PR branch and the official package provided from the curl website.

#!/bin/bash

CURL_UPDATE_VERSION=7.64.1
CURL_PATH_NAME=curl-$CURL_UPDATE_VERSION

GIT_REPO_BRANCH=vendor/curl-$CURL_UPDATE_VERSION
GIT_REPO_URL=git@github.com:multitheftauto/mtasa-blue.git
GIT_DEST_DIR=mtasa-blue
GIT_REPO_CURL_PATH=$GIT_DEST_DIR/vendor/curl/

echo 1. Download and extract $CURL_PATH_NAME...
curl https://curl.haxx.se/download/$CURL_PATH_NAME.tar.xz | tar -xJ

echo 2. Clone the vendor update branch $GIT_REPO_BRANCH from $GIT_REPO_URL into $GIT_DEST_DIR...
git clone --depth 1 -b $GIT_REPO_BRANCH $GIT_REPO_URL $GIT_DEST_DIR

echo 3. Start checking integrity...
diff -r $GIT_REPO_CURL_PATH $CURL_PATH_NAME

echo 4. Completed.

Past curl updates in MTA

Date From To Link
February 2019 7.63.0 7.64.0 (current) #819
January 2019 7.61.1 7.63.0 #744
September 2018 7.61.0 7.61.1 #428
August 2018 7.59.0 7.61.0 #271
March 2018 7.54.0 7.59.0 b99e343
June 2017 7.32.0 7.54.0 c15d999
August 2013 7.19.4 7.32.0 aaf3e21

Copy of curl changelog

Fixed in 7.64.1 - March 27 2019

Changes:

alt-svc: experiemental support added
configure: add --with-amissl

Bugfixes:

AppVeyor: add MinGW-w64 and classic Mingw builds
AppVeyor: switch VS 2015 builds to VS 2017 image
CURLU: fix NULL dereference when used over proxy
Curl_easy: remove req.maxfd - never used!
Curl_now: figure out windows version in win32_init:
Curl_resolv: fix a gcc -Werror=maybe-uninitialized warning
DoH: inherit some SSL options from user's easy handle
Secure Transport: no more "darwinssl"
Secure Transport: tvOS 11 is required for ALPN support
cirrus: Added FreeBSD builds using Cirrus CI
cleanup: make local functions static
cli tool: do not use mime.h private structures
cmdline-opts/proxytunnel.d: the option tunnnels all protocols
configure: add additional libraries to check for LDAP support
configure: remove the unused fdopen macro
configure: show features as well in the final summary
conncache: use conn->data to know if a transfer owns it
connection: never reuse CONNECT_ONLY connections
connection_check: restore original conn->data after the check
connection_check: set ->data to the transfer doing the check
cookie: Add support for cookie prefixes
cookies: dotless names can set cookies again
cookies: fix NULL dereference if flushing cookies with no CookieInfo set
curl.1: --user and --proxy-user are hidden from ps output
curl.1: mark the argument to --cookie as
curl.h: use __has_declspec_attribute for shared builds
curl: display --version features sorted alphabetically
curl: fix FreeBSD compiler warning in the --xattr code
curl: remove MANUAL from -M output
curl_easy_duphandle.3: clarify that a duped handle has no shares
curl_multi_remove_handle.3: use at any time, just not from within callbacks
curl_url.3: this API is not experimental anymore
dns: release sharelock as soon as possible
docs: update max-redirs.d phrasing
easy: fix win32 init to work without CURL_GLOBAL_WIN32
examples/10-at-a-time.c: improve readability and simplify
examples/cacertinmem.c: use multiple certificates for loading CA-chain
examples/crawler: Fix the Accept-Encoding setting
examples/ephiperfifo.c: various fixes
examples/externalsocket: add missing close socket calls
examples/http2-download: cleaned up
examples/http2-serverpush: add some sensible error checks
examples/http2-upload: cleaned up
examples/httpcustomheader: Value stored to 'res' is never read
examples/postinmemory: Potential leak of memory pointed to by 'chunk.memory'
examples/sftpuploadresume: Value stored to 'result' is never read
examples: only include
examples: remove recursive calls to curl_multi_socket_action
examples: remove superfluous null-pointer checks
file: fix "Checking if unsigned variable 'readcount' is less than zero."
fnmatch: disable if FTP is disabled
gnutls: remove call to deprecated gnutls_compression_get_name
gopher: remove check for path == NULL
gssapi: fix deprecated header warnings
hostip: make create_hostcache_id avoid alloc + free
http2: multi_connchanged() moved from multi.c, only used for h2
http2: verify :athority in push promise requests
http: make adding a blank header thread-safe
http: send payload when (proxy) authentication is done
http: set state.infilesize when sending multipart formposts
makefile: make checksrc and hugefile commands "silent"
mbedtls: make it build even if MBEDTLS_VERSION_C isn't set
mbedtls: release sessionid resources on error
memdebug: log pointer before freeing its data
memdebug: make debug-specific functions use curl_dbg_ prefix
mime: put the boundary buffer into the curl_mime struct
multi: call multi_done on connect timeouts, fixes CURLINFO_TOTAL_TIME
multi: remove verbose "Expire in" ... messages
multi: removed unused code for request retries
multi: support verbose conncache closure handle
negotiate: fix for HTTP POST with Negotiate
openssl: add support for TLS ASYNC state
openssl: if cert type is ENG and no key specified, key is ENG too
pretransfer: don't strlen() POSTFIELDS set for GET requests
rand: Fix a mismatch between comments in source and header
runtests: detect "schannel" as an alias for "winssl"
schannel: be quiet - remove verbose output
schannel: close TLS before removing conn from cache
schannel: support CALG_ECDH_EPHEM algorithm
scripts/completion.pl: also generate fish completion file
singlesocket: fix the 'sincebefore' placement
source: fix two 'nread' may be used uninitialized warnings
ssh: fix Condition '!status' is always true
ssh: loop the state machine if not done and not blocking
strerror: make the strerror function use local buffers
system_win32: move win32_init here from easy.c
test578: make it read data from the correct test
tests: Fixed XML validation errors in some test files
tests: add stderr comparison to the test suite
tests: fix multiple may be used uninitialized warnings
threaded-resolver: shutdown the resolver thread without error message
tool_cb_wrt: fix writing to Windows null device NUL
tool_getpass: termios.h is present on AmigaOS 3, but no tcgetattr/tcsetattr
tool_operate: build on AmigaOS
tool_operate: fix typecheck warning
transfer.c: do not compute length of undefined hex buffer
travis: add build using gnutls
travis: add scan-build
travis: bump the used wolfSSL version to 4.0.0
travis: enable valgrind for the iconv tests
travis: use updated compiler versions: clang 7 and gcc 8
unit1307: require FTP support
unit1651: survive curl_easy_init() fails
url/idnconvert: remove scan for <= 32 ascii values
url: change conn shutdown order to ensure SOCKETFUNCTION callbacks
urlapi: reduce variable scope, remove unreachable 'break'
urldata: convert bools to bitfields and move to end
urldata: simplify bytecounters
urlglob: Argument with 'nonnull' attribute passed null
version.c: silent scan-build even when librtmp is not enabled
vtls: rename some of the SSL functions
wolfssl: stop custom-adding curves
x509asn1: "Dereference of null pointer"
x509asn1: cleanup and unify code layout
zsh.pl: escape ':' character
zsh.pl: update regex to better match curl -h output

@patrikjuvonen patrikjuvonen added the enhancement New feature or request label Apr 27, 2019
@patrikjuvonen patrikjuvonen added this to the 1.5.7 milestone Apr 27, 2019
@patrikjuvonen patrikjuvonen self-assigned this Apr 27, 2019
Copy link
Contributor

@qaisjp qaisjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified :shipit:

@patrikjuvonen patrikjuvonen merged commit 2df47c2 into master Apr 28, 2019
@qaisjp qaisjp deleted the vendor/curl-7.64.1 branch April 28, 2019 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants