Repository navigation
Addendum to cf640af: fix Ctrl staying stuck in the GUI after Alt+Tab - #5493
Open
Flashmyname wants to merge 1 commit into
Open
Flashmyname wants to merge 1 commit into
Flashmyname wants to merge 1 commit into
Conversation
Flashmyname
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ctrl or Shift held while the window lost focus stayed pressed for the GUI, since the key-up never reaches it, so the next letter in an edit box acted as a shortcut.
Motivation
Follow-up to #5325, for the Alt+Tab case from #2609.
Test plan
In windowed mode press F8, type
hello, hold Ctrl, Alt+Tab out and release everything outside, click back and pressa. Master leavesa, with the fixhelloa. The #5325 case (Ctrl released while Alt is held) still giveshelloa.Checklist