Fix joystick not being detected after reconnecting - #5094
Open
TheCrazy17 wants to merge 2 commits into
Open
Conversation
… check, and drop one that stops responding so a replug gets noticed.
…away instead of waiting for the next retry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes MTA keep looking for a joystick after startup instead of only checking once. Covers connecting a controller after MTA is already open, reconnecting one that was unplugged, and Xbox style pads that only show up through XInput. Also listens for Windows' own device notifications so a connect or disconnect gets picked up right away instead of waiting for the next retry.
Motivation
MTA only ever checked for a joystick once, right at startup. If nothing was plugged in yet, or if you unplugged and replugged a controller mid session, it never looked again until you restarted the game.
Fixes #5088.
Test plan
Open MTA with no controller connected, then plug one in and confirm it gets picked up without restarting. Unplug it and plug it back in, confirm it keeps working.
Checklist