Skip to content

Fix missing DFT-30 middle wheel - #5084

Open
Dryxio wants to merge 1 commit into
multitheftauto:masterfrom
Dryxio:bugfix-dft-30-wheel
Open

Fix missing DFT-30 middle wheel#5084
Dryxio wants to merge 1 commit into
multitheftauto:masterfrom
Dryxio:bugfix-dft-30-wheel

Conversation

@Dryxio

@Dryxio Dryxio commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Summary

Fix the missing left middle wheel on DFT-30.

The model calls this component wheel_lm, but the game search for wheel_lm_dummy, so it is never found. The fix accepts wheel_lm when this component is searched.

Based on SilentPatch hierarchy typo fix.

PS: I planned to make one PR with all SilentPatch vehicle fixes but not sure if you prefer one fix per PR. This one only fixes DFT.

Screen before the fix :
mta-screen_2026-07-25_00-28-50

Screen after the fix :
mta-screen_2026-07-25_00-53-01

Motivation

DFT-30 has one missing middle wheel in GTA SA and MTA.

Test plan

Spawn DFT-30, the left middle wheel is now visible.

Checklist

  • Your code should follow the coding guidelines.
  • Smaller pull requests are easier to review.

@SpeedyFolf

Copy link
Copy Markdown
Contributor

Should be optional, some people might prefer to keep things vanilla, such as on our speedrunner server. I think you might as well add all of them at once. I already did #4918 but it's AI so it's probably bad.

@FileEX

FileEX commented Jul 28, 2026

Copy link
Copy Markdown
Member

Personally, I think fixes like this should be provided as an MTA resource. Similar to how the mapfixes resource was created. The resource would simply replace these models with versions that have the corrected names.

@Dryxio

Dryxio commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Personally, I think fixes like this should be provided as an MTA resource. Similar to how the mapfixes resource was created. The resource would simply replace these models with versions that have the corrected names.

fair, will work on that
what about the hunter bug? where the cockpit interior disappear when you place the camera on the right side

(https://github.com/CookiePLMonster/SilentPatch/blob/63ece88a80d666e10d70156c46a2998afd5bf3a6/SilentPatchSA/SilentPatchSA.cpp#L517)

@SpeedyFolf

Copy link
Copy Markdown
Contributor

fair, will work on that

Surely already exists, I have one https://gitlab.com/SpeedyFolf/mta-resources/-/tree/main/vehiclemodelfixes?ref_type=heads and Mr. Green Gaming has one https://github.com/MrGreenGaming/MTA-Resources/tree/master/resources/%5Brace%5D/race_fix, but I figured using code instead providing models would be better, resource/folder names can vary from server to server meaning you have to download them again. Maybe adding it to setWorldSpecialPropertyEnabled would be better than what I did, like QueryOfficial wants to add ps2scorchedvehicles to that.

@FileEX

FileEX commented Jul 29, 2026

Copy link
Copy Markdown
Member

Personally, I think fixes like this should be provided as an MTA resource. Similar to how the mapfixes resource was created. The resource would simply replace these models with versions that have the corrected names.

fair, will work on that what about the hunter bug? where the cockpit interior disappear when you place the camera on the right side

(https://github.com/CookiePLMonster/SilentPatch/blob/63ece88a80d666e10d70156c46a2998afd5bf3a6/SilentPatchSA/SilentPatchSA.cpp#L517)

Since this is a model loading issue, fixing it in the MTA code makes sense in this case

@SpeedyFolf

SpeedyFolf commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

I just remembered in 1.7 the headlights and taillights work on the Rhino and that wasn't made optional, it's a thing by default, and they don't work in singleplayer even with SilentPatch. That may be added to a future version of SilentPatch but it probably won't be a setting, the vehicle model hierarchy typo fixes isn't a setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants